Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to fake interaction videos with blocks #3922

Merged
merged 11 commits into from
Oct 13, 2024

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Jun 2, 2024
@jkrumbiegel jkrumbiegel marked this pull request as draft June 2, 2024 21:05
@MakieBot
Copy link
Collaborator

MakieBot commented Jun 9, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 5.11s (5.06, 5.14) 0.02+- 112.59ms (108.05, 123.15) 5.16+- 420.34ms (416.93, 431.66) 5.40+- 9.51ms (9.40, 9.64) 0.08+- 25.98ms (25.91, 26.07) 0.06+-
master 5.12s (5.08, 5.16) 0.02+- 111.01ms (109.45, 112.44) 1.13+- 417.82ms (414.49, 423.76) 3.03+- 9.59ms (9.51, 9.67) 0.06+- 26.00ms (25.95, 26.06) 0.05+-
evaluation 1.00x invariant, -0.02s (-0.64d, 0.25p, 0.02std) 0.99x invariant, 1.58ms (0.42d, 0.46p, 3.15std) 0.99x invariant, 2.52ms (0.58d, 0.31p, 4.21std) 1.01x invariant, -0.08ms (-1.17d, 0.05p, 0.07std) 1.00x invariant, -0.02ms (-0.37d, 0.50p, 0.05std)
CairoMakie 4.89s (4.83, 4.95) 0.05+- 111.24ms (108.62, 115.06) 2.15+- 168.60ms (164.86, 175.92) 3.52+- 9.53ms (9.15, 9.91) 0.22+- 1.22ms (1.16, 1.23) 0.02+-
master 4.81s (4.75, 4.87) 0.04+- 110.21ms (109.20, 111.99) 0.99+- 167.44ms (165.12, 169.76) 1.59+- 9.23ms (9.10, 9.31) 0.07+- 1.17ms (1.14, 1.25) 0.04+-
evaluation 0.98x slower X, 0.08s (1.77d, 0.01p, 0.04std) 0.99x invariant, 1.02ms (0.61d, 0.29p, 1.57std) 0.99x invariant, 1.16ms (0.43d, 0.45p, 2.55std) 0.97x slower X, 0.3ms (1.80d, 0.01p, 0.15std) 0.96x slower X, 0.05ms (1.49d, 0.02p, 0.03std)
WGLMakie 5.60s (5.45, 5.74) 0.11+- 119.25ms (113.95, 129.28) 5.28+- 5.82s (5.58, 6.09) 0.19+- 13.36ms (12.28, 15.93) 1.21+- 119.58ms (116.77, 126.56) 3.61+-
master 5.66s (5.49, 5.80) 0.11+- 125.09ms (115.69, 138.70) 7.88+- 5.83s (5.69, 6.02) 0.12+- 13.99ms (13.14, 14.49) 0.55+- 117.76ms (112.58, 120.65) 3.12+-
evaluation 1.01x invariant, -0.06s (-0.57d, 0.31p, 0.11std) 1.05x invariant, -5.84ms (-0.87d, 0.13p, 6.58std) 1.00x invariant, -0.01s (-0.04d, 0.94p, 0.16std) 1.05x invariant, -0.63ms (-0.67d, 0.24p, 0.88std) 0.98x invariant, 1.82ms (0.54d, 0.33p, 3.36std)

@jkrumbiegel
Copy link
Member Author

This is mostly ready now, examples look pretty good I think. I don't really see a way around the increased rendering time, as we can't go parallel and CI machines are just not that quick. But it seems worth it to me to actually show the UI in action.

@SimonDanisch SimonDanisch marked this pull request as ready for review September 24, 2024 17:59
@SimonDanisch
Copy link
Member

I think the increase is fine, considering that it's still not the slowest CI ;)

@jkrumbiegel jkrumbiegel merged commit beb39c5 into master Oct 13, 2024
16 checks passed
@jkrumbiegel jkrumbiegel deleted the jk/fake-interactions branch October 13, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants