move throttle_function to Bonito #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonito's StylableSlider needs to be throttled. see SimonDanisch/Bonito.jl#233 (which needs to be merged before this one). instead of duplicating
throttle_functionin Bonito, move it there, and have WGLMakie rely on that.this is neither a bug fix nor new feature nor breaking change to Makie, but does improve user experience in Bonito while minimizing code duplication.
that being said and done, since Makie text boxes now work in Bonito (#3924, yay!!!), i have no need for Bonito sliders as my entire GUI can be in Makie now. but other folks still might find this PR useful.