Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change camera variables to Float64 #3984

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Change camera variables to Float64 #3984

merged 9 commits into from
Jun 28, 2024

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jun 22, 2024

Description

Fixes #3979

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Jun 22, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.58s (4.46, 4.68) 0.08+- 112.06ms (108.20, 117.99) 3.41+- 515.96ms (509.77, 525.24) 5.06+- 9.04ms (8.77, 9.56) 0.27+- 26.50ms (26.29, 26.91) 0.23+-
master 4.61s (4.50, 4.68) 0.06+- 116.24ms (111.38, 121.87) 3.27+- 526.34ms (505.89, 546.71) 12.64+- 9.03ms (8.76, 9.25) 0.16+- 26.54ms (26.25, 26.71) 0.15+-
evaluation 1.01x invariant, -0.03s (-0.45d, 0.42p, 0.07std) 1.04x faster ✓, -4.17ms (-1.25d, 0.04p, 3.34std) 1.02x invariant, -10.38ms (-1.08d, 0.08p, 8.85std) 1.00x invariant, 0.01ms (0.04d, 0.94p, 0.21std) 1.00x invariant, -0.04ms (-0.22d, 0.69p, 0.19std)
CairoMakie 3.92s (3.87, 4.00) 0.05+- 107.18ms (105.75, 112.39) 2.37+- 131.52ms (129.35, 133.86) 1.62+- 8.44ms (8.37, 8.54) 0.08+- 1.01ms (1.01, 1.02) 0.01+-
master 3.67s (3.64, 3.70) 0.03+- 107.23ms (105.15, 113.47) 2.88+- 131.39ms (129.62, 139.36) 3.58+- 8.21ms (8.09, 8.43) 0.14+- 975.79μs (969.82, 985.13) 4.83+-
evaluation 0.94x slower❌, 0.25s (6.58d, 0.00p, 0.04std) 1.00x invariant, -0.04ms (-0.02d, 0.98p, 2.62std) 1.00x invariant, 0.13ms (0.05d, 0.93p, 2.60std) 0.97x slower X, 0.23ms (2.08d, 0.00p, 0.11std) 0.96x slower X, 0.04ms (7.16d, 0.00p, 0.01std)
WGLMakie 4.39s (4.34, 4.43) 0.04+- 105.98ms (103.76, 111.61) 2.70+- 8.83s (8.69, 8.93) 0.10+- 10.06ms (9.04, 10.39) 0.47+- 71.78ms (69.59, 82.62) 4.80+-
master 4.45s (4.40, 4.51) 0.04+- 105.73ms (102.95, 109.53) 2.38+- 9.02s (8.87, 9.18) 0.12+- 9.44ms (9.02, 10.44) 0.46+- 70.29ms (69.54, 71.41) 0.68+-
evaluation 1.02x faster ✓, -0.07s (-1.64d, 0.01p, 0.04std) 1.00x invariant, 0.25ms (0.10d, 0.86p, 2.54std) 1.02x faster ✓, -0.19s (-1.78d, 0.01p, 0.11std) 0.94x slower❌, 0.62ms (1.34d, 0.03p, 0.47std) 0.98x invariant, 1.49ms (0.43d, 0.45p, 2.74std)

@ffreyer ffreyer marked this pull request as ready for review June 22, 2024 16:54
@ffreyer
Copy link
Collaborator Author

ffreyer commented Jun 22, 2024

The CairoMakie error is "Merged color Mesh". Since that has z-fighting issues it's not surprising it fails when changing types involved in point projections.

@SimonDanisch SimonDanisch merged commit 90d88e5 into master Jun 28, 2024
18 checks passed
@SimonDanisch SimonDanisch deleted the ff/f64_camera branch June 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D axis broken in GLMakie v0.10.13
3 participants