Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve CairoMakie insert! ambiguity #4038

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Jul 15, 2024

Description

Before:

julia> plotlist([Makie.SpecApi.Scatter(1:10)])

julia> plotlist!([Makie.SpecApi.Scatter(1:10)])
ERROR: MethodError: insert!(::CairoMakie.Screen{CairoMakie.IMAGE}, ::Scene, ::Plot{Makie.plotlist, Tuple{Vector{PlotSpec}}}) is ambiguous.

Candidates:
  insert!(screen::CairoMakie.Screen, scene::Scene, plot)
    @ CairoMakie ~/.julia/packages/CairoMakie/wKKMp/src/screen.jl:206
  insert!(::MakieScreen, ::Scene, ::Plot{Makie.plotlist})
    @ Makie ~/.julia/packages/Makie/rEu75/src/specapi.jl:387

Possible fix, define
  insert!(::CairoMakie.Screen, ::Scene, ::Plot{Makie.plotlist})

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added unit tests for new algorithms, conversion methods, etc.

CairoMakie/src/screen.jl Show resolved Hide resolved
CairoMakie/test/runtests.jl Outdated Show resolved Hide resolved
@aplavin
Copy link
Contributor Author

aplavin commented Jul 16, 2024

Updated! Should be fine now.

@SimonDanisch SimonDanisch merged commit 77f2cfd into MakieOrg:master Jul 16, 2024
18 checks passed
@asinghvi17
Copy link
Member

thanks @aplavin!

@aplavin aplavin deleted the patch-4 branch July 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants