-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Relocatability for GLMakie and fix tests #4461
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
+100 for all improvements to relocatability! there is also a similar outstanding PR for WGLMakie. still haven't found the time to finish that up. |
use `run` to get printouts and `finally` to not swallow errors in `catch`
The tests didn't really test relocatability, since we only moved the package dir, but not the GLMakie source code.
This changes GLMakie to load all shaders on precompile, to make them part of the system image, much like what RelocatableFolder does it, but more explicitely (since we're caching + loading the shaders anyways).
Also deletes some dead code.