-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plots to move between scenes in SpecApi #4478
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
…into sd/move-plots
Benchmark ResultsSHA: 46f73d1926dca187403c95ba012d5399e616e2d3 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
…into sd/move-plots
…into sd/move-plots
* refactor JS Plot object to be movable * allow to move plots between scenes * correctly close channel * re-use plots, that got moved between axes * remove lock * fix specapi * fix makie tests * fix CairoMakie * Update CHANGELOG.md * try showing more infos * implement moveto! correctly for GLMakie and test for all backends * test & fix move_to! * add another test * make move_to optional * revert GLMakie changes * revert more changes * fix WGLMakie move_to * rename test * improve tests * clean up test
This isn't perfect yet, since it needs quite a few features from #4360 to work properly for all backends.
The introduced
move_to!
will stay an internal API for now, that are only used for WGLMakie right now inside SpecApi when it's safe to use.I expect to implement this cleanly for all backends in #4360.