Revert "feat: allow option to invert lines"

This reverts commit 9093a91.
Malaa-tech · Nov 13, 2023 · b1965b6 · b1965b6
1 parent ea04c1d
commit b1965b6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 38 deletions.
diff --git a/src/LineChart.tsx b/src/LineChart.tsx
@@ -43,10 +43,6 @@ const getExtraConfig = (extraConfig: ExtraConfig): ExtraConfig => {
     activeOffsetX: extraConfig.activeOffsetX || EXTRA_CONFIG.activeOffsetX,
     animationConfig:
       extraConfig.animationConfig || EXTRA_CONFIG.animationConfig,
-    invertLineOrder:
-      extraConfig.invertLineOrder !== undefined
-        ? extraConfig.invertLineOrder
-        : EXTRA_CONFIG.invertLineOrder,
   };
 };
 function LineChart({

diff --git a/src/SvgPath.tsx b/src/SvgPath.tsx
@@ -4,7 +4,6 @@ import React, {
   ReactElement,
   useCallback,
   useEffect,
-  useMemo,
 } from 'react';
 import {
   interpolate,
@@ -88,35 +87,30 @@ const SvgPath = ({
     return activeIndexLocal;
   }, [activeTouchX, lines[0]?.data]);
 
-  const checkedLines = useMemo(() => {
-    if (extraConfig?.invertLineOrder) {
-      return [...lines].reverse();
-    }
-    return lines;
-  }, [lines, extraConfig?.invertLineOrder]);
-
   return (
     <>
-      {checkedLines.map((line, index) => {
-        if (line?.data) {
-          return (
-            <MemoizedLineComponent
-              key={`${index}`}
-              line={line}
-              allData={allData}
-              svgHeight={svgHeight}
-              svgWidth={svgWidth}
-              activeIndex={activeIndex}
-              activeTouch={activeTouch}
-              identifier={`${index}`}
-              extraConfig={extraConfig}
-              onPointChange={index === 0 ? onPointChange : undefined}
-            />
-          );
-        }
-        // @ts-ignore
-        return <View key={`${index}`} />;
-      })}
+      {lines
+        .filter((line) => line?.data)
+        .map((line, index) => {
+          if (line?.data) {
+            return (
+              <MemoizedLineComponent
+                key={`${index}`}
+                line={line}
+                allData={allData}
+                svgHeight={svgHeight}
+                svgWidth={svgWidth}
+                activeIndex={activeIndex}
+                activeTouch={activeTouch}
+                identifier={`${index}`}
+                extraConfig={extraConfig}
+                onPointChange={index === 0 ? onPointChange : undefined}
+              />
+            );
+          }
+          // @ts-ignore
+          return <View key={`${index}`} />;
+        })}
     </>
   );
 };

diff --git a/src/defaults.tsx b/src/defaults.tsx
@@ -29,7 +29,6 @@ export const EXTRA_CONFIG = {
   calculateChartYAxisMinMax: undefined,
   activeOffsetX: [0, 0],
   animationConfig: undefined,
-  invertLineOrder: false,
 };
 
 export const LINE_CHART = {

diff --git a/src/types.ts b/src/types.ts
@@ -221,11 +221,6 @@ export interface ExtraConfig {
    * Animation configuration
    */
   animationConfig?: AnimationConfig;
-  /**
-   * Invert the order of the lines (useful when you want to show the last line on top)
-   * @default false
-   */
-  invertLineOrder?: boolean;
 }
 
 /**