Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use core's before_install after cloning it #744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 7, 2022

Trying out sharing the "before_install" script from core.

@Fryguy Fryguy requested a review from agrare as a code owner February 7, 2022 18:57
@chessbyte chessbyte self-assigned this Feb 7, 2022
@Fryguy Fryguy changed the title Use core's before_install after cloning it [WIP] Use core's before_install after cloning it Feb 7, 2022
@miq-bot miq-bot added the wip label Feb 7, 2022
@Fryguy
Copy link
Member Author

Fryguy commented Feb 7, 2022

Not sure about this one just yet...I'm also refactoring core, and this might go away.

@Fryguy
Copy link
Member Author

Fryguy commented May 4, 2022

cc @agrare Just wanted to bring your attention to this after your blaster outer in #768

@kbrock kbrock assigned agrare and unassigned chessbyte May 18, 2022
@kbrock
Copy link
Member

kbrock commented May 18, 2022

@Fryguy can you rebase/un WIP this?
Seems it would be ready, especially after adam's before_install blaster outer.
(or seems it could just be closed)

@miq-bot
Copy link
Member

miq-bot commented May 25, 2022

Checked commit Fryguy@cfbe40a with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 13, 2023
@miq-bot miq-bot added the stale label Jun 19, 2023
@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Jun 19, 2023
@miq-bot miq-bot added the stale label Sep 25, 2023
@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Jan 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Apr 8, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Jul 15, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants