Fix Azure NetworkManager refresh disconnecting managed_images #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All refreshes should be done via the CloudManager, instance methods are delegated to the network_manager's parent_manager however the class-level refresh_ems method was not being delegated causing failures and disconnected inventory.
agrare
changed the title
agrare
force-pushed
the
fix_refresh_ems_class_method_not_delegated
branch
from
0abbe16
to
d1c796a
Compare
|
NOTE these changes are something which we should match in the other providers as well to prevent extra work from being done, but this is more important because here the collector settings cause images to be disconnected. |
Fryguy
approved these changes
Oct 29, 2024
This was referenced Oct 30, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All refreshes should be done via the CloudManager, instance methods are delegated to the network_manager's parent_manager however the class-level refresh_ems method was not being delegated causing failures and disconnected inventory.
NOTE this was called via the scheduled
refresh_all_ems_timermethod, this currently goes through all permitted subclasses which includes the child managers like these Network and Storage managers under a parent cloud manager. At best this is a duplicate full refresh and at worst in this case it exposes bugs like this. I'd like to tackle running a full refresh on a timer only for the "primary" class (where that is going to differ provider to provider) in a separate pr.Fixes #563