Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure NetworkManager refresh disconnecting managed_images #564

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 24, 2024

All refreshes should be done via the CloudManager, instance methods are delegated to the network_manager's parent_manager however the class-level refresh_ems method was not being delegated causing failures and disconnected inventory.

NOTE this was called via the scheduled refresh_all_ems_timer method, this currently goes through all permitted subclasses which includes the child managers like these Network and Storage managers under a parent cloud manager. At best this is a duplicate full refresh and at worst in this case it exposes bugs like this. I'd like to tackle running a full refresh on a timer only for the "primary" class (where that is going to differ provider to provider) in a separate pr.

Fixes #563

All refreshes should be done via the CloudManager, instance methods are
delegated to the network_manager's parent_manager however the
class-level refresh_ems method was not being delegated causing failures
and disconnected inventory.
@agrare agrare changed the title Fix Azure NetworkManager refresh not delegated Fix Azure NetworkManager refresh disconnecting managed_images Oct 24, 2024
@agrare agrare closed this Oct 24, 2024
@agrare agrare reopened this Oct 24, 2024
@agrare agrare force-pushed the fix_refresh_ems_class_method_not_delegated branch from 0abbe16 to d1c796a Compare October 29, 2024 18:23
@agrare
Copy link
Member Author

agrare commented Oct 29, 2024

NOTE these changes are something which we should match in the other providers as well to prevent extra work from being done, but this is more important because here the collector settings cause images to be disconnected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing Azure NetworkManager disconnects all managed_images
2 participants