Merge pull request #674 from agrare/fix_ovirt_vm_smartstate_supports_…

…typo

Fix typo in Ovirt VM supports?(:smartstate_analysis)

app/models/manageiq/providers/ovirt/infra_manager/vm_or_template_shared/scanning.rb

@@ -8,7 +8,7 @@ module ManageIQ::Providers::Ovirt::InfraManager::VmOrTemplateShared::Scanning
       elsif !storage.storage_type_supported_for_ssa?
         "Smartstate Analysis unsupported for storage type %{store_type}" % {:store_type => storage.store_type}
       else
-        unuspported_reason(:action)
+        unsupported_reason(:action)
       end
     end
   end

spec/models/manageiq/providers/ovirt/infra_manager/vm_spec.rb

@@ -57,6 +57,41 @@
     end
   end
 
+  describe "supports?(:smartstate_analysis)" do
+    let(:vm) { FactoryBot.create(:vm_ovirt, :ext_management_system => ems, :host => host, :storage => storage) }
+
+    context "without a storage" do
+      let(:storage) { nil }
+
+      it "returns false" do
+        expect(vm.supports?(:smartstate_analysis)).to be_falsey
+        expect(vm.unsupported_reason(:smartstate_analysis)).to eq("Vm is not located on a storage")
+      end
+    end
+
+    context "with a storage" do
+      let(:storage) { FactoryBot.create(:storage_ovirt, :store_type => store_type) }
+
+      context "with a supported store_type" do
+        let(:store_type) { "NFS" }
+
+        it "returns false" do
+          expect(vm.supports?(:smartstate_analysis)).to be_truthy
+          expect(vm.unsupported_reason(:smartstate_analysis)).to be_nil
+        end
+      end
+
+      context "with an unsupported store_type" do
+        let(:store_type) { "BAD-STORE-TYPE" }
+
+        it "returns false" do
+          expect(vm.supports?(:smartstate_analysis)).to be_falsey
+          expect(vm.unsupported_reason(:smartstate_analysis)).to eq("Smartstate Analysis unsupported for storage type BAD-STORE-TYPE")
+        end
+      end
+    end
+  end
+
   context "#calculate_power_state" do
     it "returns suspended when suspended" do
       expect(described_class.calculate_power_state('suspended')).to eq('suspended')