-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ovirt-engine-sdk to 4.6 #676
Conversation
Updating gem because it fixes some issues with 3.3 building
49114cc
to
0a37bc7
Compare
update:
|
Strange that we set ovirt_engine_sdk at all in red_hat_virtualization since it inherits from this gem anyway. |
@Fryguy cool. I'll drop and see what happens I don't see the inheritance red_hat_virtualization.gemspec spec.add_dependency "ovirt-engine-sdk", "~>4.6.0"
spec.add_dependency "ovirt_metrics", "~>3.2" |
The inheritance is kind of implied, but I don't see why we couldn't add a line to the gemspec to introduce it. Something over there like spec.add_dependency "manageiq-providers-ovirt" |
@miq-bot cross_repo_test #676 including ManageIQ/ovirt#118 |
From Pull Request: ManageIQ/manageiq-providers-ovirt#676
I updated red_hat_virtualization to depend upon this gem So I think this will be resolved once ManageIQ/manageiq-providers-red_hat_virtualization#54 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to see cross-repo go green, ideally with red_hat_virtualization in there. @kbrock can you update the cross-repo test to drop ovirt and add manageiq-providers-red_hat_virtualization?
Updating gem because it fixes some issues with ruby 3.3 building
Gem released Feb 1, 2024
I have no idea if I'm breaking anything here.
Just trying to make ruby 3.2 compile