Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovirt-engine-sdk to 4.6 #676

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 10, 2024

Updating gem because it fixes some issues with ruby 3.3 building

Gem released Feb 1, 2024

I have no idea if I'm breaking anything here.
Just trying to make ruby 3.2 compile

Updating gem because it fixes some issues with 3.3 building
@kbrock
Copy link
Member Author

kbrock commented Sep 10, 2024

update:

  • changed from 4.6.1 to 4.6.0 (I misread ruby gems)

@Fryguy
Copy link
Member

Fryguy commented Sep 10, 2024

Strange that we set ovirt_engine_sdk at all in red_hat_virtualization since it inherits from this gem anyway.

@kbrock
Copy link
Member Author

kbrock commented Sep 10, 2024

@Fryguy cool. I'll drop and see what happens

I don't see the inheritance red_hat_virtualization.gemspec

  spec.add_dependency "ovirt-engine-sdk", "~>4.6.0"
  spec.add_dependency "ovirt_metrics", "~>3.2"

@Fryguy
Copy link
Member

Fryguy commented Sep 10, 2024

The inheritance is kind of implied, but I don't see why we couldn't add a line to the gemspec to introduce it.

Something over there like

  spec.add_dependency "manageiq-providers-ovirt"

@kbrock
Copy link
Member Author

kbrock commented Sep 10, 2024

@miq-bot cross_repo_test #676 including ManageIQ/ovirt#118

@agrare
Copy link
Member

agrare commented Sep 10, 2024

@kbrock I see you included the "ovirt" gem in cross-repo, I don't think it is actually used any longer after 44446d6

@kbrock
Copy link
Member Author

kbrock commented Sep 10, 2024

Bundler could not find compatible versions for gem "ovirt-engine-sdk":
  In Gemfile:
    manageiq-providers-ovirt was resolved to 0.1.0, which depends on
      ovirt-engine-sdk (~> 4.6.0)

manageiq-providers-red_hat_virtualization was resolved to 0.1.0, which
depends on
      ovirt-engine-sdk (~> 4.4.0)

I updated red_hat_virtualization to depend upon this gem
and no longer specify ovirt-engine-sdk.

So I think this will be resolved once ManageIQ/manageiq-providers-red_hat_virtualization#54 is merged

@agrare agrare closed this Sep 10, 2024
@agrare agrare reopened this Sep 10, 2024
@kbrock kbrock changed the title Update ovirt to 4.6 Update ovirt-engine-sdk to 4.6 Sep 10, 2024
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to see cross-repo go green, ideally with red_hat_virtualization in there. @kbrock can you update the cross-repo test to drop ovirt and add manageiq-providers-red_hat_virtualization?

@Fryguy Fryguy merged commit 7174d91 into ManageIQ:master Sep 10, 2024
3 of 6 checks passed
@Fryguy Fryguy self-assigned this Sep 10, 2024
@kbrock kbrock deleted the latest-ovirt branch September 10, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants