Don't delegate NetworkManager#zone to parent_manager #886
Conversation
The zone_id is synchronized when the parent_manager is saved so this delegation causes issues with pausing the parent provider
| @@ -19,7 +19,6 @@ class ManageIQ::Providers::Vmware::NetworkManager < ManageIQ::Providers::Network | |||
| :authentication_status_ok?, | |||
| :authentications, | |||
| :authentication_for_summary, | |||
| :zone, | |||
There was a problem hiding this comment.
Was zone included here for a valid reason? I'm curious why it was delegated in the first place.
There was a problem hiding this comment.
some places we use zone and other places we use zone_id
we tried to replicate the zone across from parent to child, but the autosave makes it a little tricky
There was a problem hiding this comment.
This is how we handled keeping zone "in sync" with the parent manager originally, but we found that (specifically in the per_ems_worker_mixin code) doing ExtManagementSystem.where(:zone => my_zone) these were not picked up.
We now have callbacks that set child.zone_id = zone_id when the cloud_manager is updated.
|
Checked commit agrare@27e9f72 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
The zone_id is synchronized when the parent_manager is saved so this delegation causes issues with pausing the parent provider
#885
https://github.com/ManageIQ/manageiq/actions/runs/6306276756/job/17121144898#step:8:353