Customizable chart top values (dropdown choices)

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
ManageIQ · Jun 16, 2023 · 2594c31 · 2594c31
1 parent bacd478
commit 2594c31
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/report_controller/reports/editor.rb b/app/controllers/report_controller/reports/editor.rb
@@ -9,7 +9,7 @@ module ReportController::Reports::Editor
   DEFAULT_PDF_PAGE_SIZE = "US-Letter".freeze
 
   MAX_REPORT_COLUMNS = 100 # Default maximum number of columns in a report
-  GRAPH_MAX_COUNT = 10
+  GRAPH_MAX_COUNT = ::Settings.reporting.chart_top_values || 10
 
   CHAREGEBACK_ALLOCATED_METHODS = {
     :max => N_('Maximum'),
@@ -653,7 +653,7 @@ def gfv_charts
     end
 
     if params[:chosen_count] && params[:chosen_count] != @edit[:new][:graph_count]
-      @edit[:new][:graph_count] = params[:chosen_count]
+      @edit[:new][:graph_count] = params[:chosen_count].to_i
       @refresh_div              = "chart_sample_div"
       @refresh_partial          = "form_chart_sample"
     end

diff --git a/spec/controllers/report_controller_spec.rb b/spec/controllers/report_controller_spec.rb
@@ -439,7 +439,7 @@
         end
 
         it "sets top values to show" do
-          top_val = "3"
+          top_val = 3
           controller.params = {:chosen_count => top_val}
           controller.send(:gfv_charts)
           expect(assigns(:edit)[:new][:graph_count]).to eq(top_val)