Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Embedded Workflow integration #8718

Closed
wants to merge 2 commits into from

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Mar 17, 2023

Nav Menu Links
image

Workflows - ( using playbook model in the controller)

  • Show List - /workflow/show_list#/
  • Component: WorkflowList - uses dummy data (thinking of reusing this for repositories and credentials if required)
  • Show page - /workflow/show/6#/
  • Component: WorkflowSummary- uses dummy data
  • Tabs in WorkflowSummary
    1. Text - Display the JSON object in CodeSnippet
    1. Graph - Display the graph using '@tshepomgaga/aws-sfn-graph' package

Repositories

  • Show List - /workflow_repository/show_list#/
  • Show page - /workflow_repository/show/6#/

Credentials

  • Show List - /workflow_credential/show_list#/
  • Show page - /workflow_credential/show/6#/

Latest update - #8718 (comment)

Related PRs

  • Manageiq
  • UI-Classic
  • Ui components

@jeffibm jeffibm requested a review from a team as a code owner March 17, 2023 14:24
@miq-bot miq-bot added the wip label Mar 17, 2023
include Mixins::BreadcrumbsMixin

def self.model
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook
Copy link
Member Author

@jeffibm jeffibm Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fryguy , I don't know which model has to be used here. For now I had used Playbook just so that to see that the page works till here..(I am blocked here)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ManageIQ::Providers::Workflows::AutomationManager::Workflow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess we need to add something somewhere else for this to work..

[2023-03-30T19:31:47.507212 #5181:5ae4c] FATAL -- : Error caught: [Errno::ENOENT] No such file or directory - Unable to find view yaml file for db "ManageIQ_Providers_Workflows_AutomationManager_Workflow"
/Users/jeffreybonson/Workspace/manageiq/app/models/miq_report/import_export.rb:110:in `load_from_view_options'
/Users/jeffreybonson/Workspace/manageiq-ui-classic/app/controllers/application_controller.rb:1305:in `get_db_view'
/Users/jeffreybonson/Workspace/manageiq-ui-classic/app/controllers/application_controller.rb:1160:in `get_view'
/Users/jeffreybonson/Workspace/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:189:in `process_show_list'
/Users/jeffreybonson/Workspace/manageiq-ui-classic/app/controllers/mixins/generic_list_mixin.rb:10:in `show_list'
/Users/jeffreybonson/Workspace/manageiq-ui-classic/app/controllers/automated_workflow_controller.rb:19:in `show_list'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/abstract_controller/base.rb:228:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/rendering.rb:30:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:106:in `run_callbacks'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/abstract_controller/callbacks.rb:41:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/rescue.rb:22:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/activesupport-6.1.7.3/lib/active_support/notifications.rb:203:in `block in instrument'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/activesupport-6.1.7.3/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/activesupport-6.1.7.3/lib/active_support/notifications.rb:203:in `instrument'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal/params_wrapper.rb:249:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/activerecord-6.1.7.3/lib/active_record/railties/controller_runtime.rb:27:in `process_action'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/abstract_controller/base.rb:165:in `process'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionview-6.1.7.3/lib/action_view/rendering.rb:39:in `process'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal.rb:190:in `dispatch'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_controller/metal.rb:254:in `dispatch'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:33:in `serve'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:50:in `block in serve'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:32:in `each'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:32:in `serve'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:842:in `call'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/rack-attack-6.5.0/lib/rack/attack.rb:113:in `call'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/routes_lazy_routes-0.4.2/lib/routes_lazy_routes/lazy_routes_middleware.rb:16:in `call'
/Users/jeffreybonson/Workspace/manageiq/lib/request_started_on_middleware.rb:12:in `call'
/Users/jeffreybonson/.rvm/gems/ruby-3.0.5@master/gems/rack-2.2.6.4/lib/rack/tempfile_reaper.rb:15:in `call'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every list view screen requires a report file which defines the table structure - the name of the file matches the model.

@jeffibm
Copy link
Member Author

jeffibm commented Mar 23, 2023

image

@jeffibm
Copy link
Member Author

jeffibm commented Mar 24, 2023

This was accomplished using dummy data

Screen.Recording.2023-03-24.at.7.24.44.PM.mov

List Page
image

Summary Page
image

@jeffibm jeffibm force-pushed the jbn-automated-workflows-1 branch 2 times, most recently from 617b0ca to 5a61565 Compare March 24, 2023 09:48
@jeffibm
Copy link
Member Author

jeffibm commented Mar 27, 2023

Created tabs present the Text and Graph
image
image

@Fryguy
Copy link
Member

Fryguy commented Mar 29, 2023

@jeffibm See ManageIQ/manageiq#22429 for the feature names for RBAC

@@ -0,0 +1,158 @@
/* **********************************************************
* This file contains dummy data for List and Summary Page.
* This file can be removed when we have API's in place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIs will be in ManageIQ/manageiq-api#1214

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffibm So, I talked with @agrare, and here's what we've decided naming wise.

Menus will looks like

Automation -> Embedded Workflows -> Workflows
Automation -> Embedded Workflows -> Repositories
Automation -> Embedded Workflows -> Credentials

While the Embedded will be in the UI for now, it's only for consistency with Embedded Ansible and Embedded Automate. Eventually, we're thinking of reorganizing it to get rid of the "Embedded" terminology everywhere because it's redundant, but for now we have to at least keep it in the menus.

So, given that, this controller should be named workflow_controller.rb.

Comment on lines 13 to 14
{ name: 'json', text: 'JSON Data' },
{ name: 'graph', text: 'Graph' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoulld these be i18n or does that happen elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make it i18 here.


const AutomatedWorkflowSummary = ({ recordId }) => {
const tabLabels = [
{ name: 'json', text: 'JSON Data' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this shouldn't say JSON, even though the format is JSON. Technically it's Amazon States Language or ASL. I'm thinking it should say either Text or ASL for this tab. @agrare Thoughts?

import { automatedWorkflowData } from './automated-workflows-dummy-data';
import '@tshepomgaga/aws-sfn-graph/index.css';

const AutomatedWorkflowSummary = ({ recordId }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment above, let's leave out the word Automated or Embedded, so this should just be WorkflowSummary and the file path should be javascript/components/workflows/summary.jsx

Same comment goes for the other .jsx files and directories.

});
};

/** Function to render the code snipper component */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Function to render the code snipper component */
/** Function to render the code snippet component */

const renderCodeSnippet = () => {
console.log(data.jsonData);
return (
<CodeSnippet type="multi">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a way to present code already that uses CodeMirror (e.g. what we use for the Ruby code in Automate and the YAML in Advanced Settings). We should reuse that component, and also use code syntax coloring for JSON.

@Fryguy
Copy link
Member

Fryguy commented Mar 29, 2023

Loving this PR!

On a separate note, there's no specs running on this PR for some reason.

@Fryguy Fryguy closed this Mar 29, 2023
@Fryguy Fryguy reopened this Mar 29, 2023
@jeffibm jeffibm changed the title [WIP] Automated Workflows for POC implementation [WIP] Embedded Workflow integration Mar 30, 2023
@jeffibm
Copy link
Member Author

jeffibm commented Apr 4, 2023

Integrated the API

Screen.Recording.2023-04-04.at.11.02.37.AM.mov

include Mixins::BreadcrumbsMixin

def self.model
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook
ManageIQ::Providers::Workflows::AutomationManager::Workflow

include Mixins::BreadcrumbsMixin

def self.model
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Playbook
ManageIQ::Providers::Workflows::AutomationManager::Repository

@agrare Is this one ready yet? I can't recall.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I didn't think we needed to subclass GitRepository

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need git support at minimum for MVP.

Copy link
Member

@agrare agrare Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I agree, but do we need to subclass GitRepository ? Could we use the existing screens/APIs for managing git repositories and just allow selecting one when importing a Workflow via the UI

@Fryguy
Copy link
Member

Fryguy commented Apr 4, 2023

@jeffibm I think we're close to being in a position to merge, but before we do I'd like this behind the prototype flag. We probably should gate the routes and the menus at a minimum - not sure on the roles or the permissions (I don't think it's possible to but those behind prototype), but that might be ok.

@jeffibm
Copy link
Member Author

jeffibm commented Apr 5, 2023

May I rebase this PR? already been 21 commits for 20 file changes.

@@ -51,6 +51,9 @@ const CodeEditor = (props) => {
{ modes.map((mode) => <RadioButton value={mode} labelText={mode} key={mode} />) }
</RadioButtonGroup>
)}
{
console.log(codeMode)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove this

@jeffibm
Copy link
Member Author

jeffibm commented Apr 19, 2023

Adding dropdown options to service catalog item's provision entry points

Screen.Recording.2023-04-19.at.2.53.00.PM.mov

Also added the same options for reconfigure and retirement entry points
image

@noopurAg
Copy link

noopurAg commented Apr 20, 2023

I tried this change as suggested by @Fryguy
image
But getting this error
image

@jeffibm
Copy link
Member Author

jeffibm commented Apr 22, 2023

noopurAg/ui-components#2

Screen.Recording.2023-04-22.at.11.39.58.AM.mov

@agrare
Copy link
Member

agrare commented Apr 24, 2023

@jeffibm can we simplify this so that we can get the basics merged?
We can tackle some of this in follow-ups, can we get the simple menu items for the Embedded Workflow section, Workflows, and Credentials (Repositories can come later and depend on a pending core change)

@jeffibm
Copy link
Member Author

jeffibm commented Apr 25, 2023

@jeffibm can we simplify this so that we can get the basics merged?
We can tackle some of this in follow-ups, can we get the simple menu items for the Embedded Workflow section, Workflows, and Credentials (Repositories can come later and depend on a pending core change)

yes, we will work on them next. Could you please provide us a checklist of Todo items with descriptions to keep track of the tasks..

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "manageiq-ui-classic",
"version": "1.0.0",
"description": "ManageIQ Cloud Management Platform",
"description": "ManageIQ Cloud Management Platform ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there was a test PR (with a simple change) to check if forking and merging work correctly between 2 users. will change it back soon.

@miq-bot
Copy link
Member

miq-bot commented May 16, 2023

Checked commits jeffbonson/manageiq-ui-classic@b37ad2e~...e4c30ca with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
17 files checked, 134 offenses detected

app/controllers/workflow_controller.rb

app/presenters/menu/default_menu.rb

app/views/catalog/_embedded_workflows_modal.html.haml

  • ⚠️ - Line 1 - Do not use inline style attributes
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.

app/views/catalog/_form_basic_info.html.haml

  • ⚠️ - Line 168 - Do not use inline style attributes
  • ⚠️ - Line 169 - Avoid using instance variables in partials views
  • ⚠️ - Line 171 - Avoid using instance variables in partials views
  • ⚠️ - Line 171 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 171 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 178 - Do not use inline style attributes
  • ⚠️ - Line 178 - id attribute must be in lisp-case
  • ⚠️ - Line 184 - Do not use inline style attributes
  • ⚠️ - Line 185 - Avoid using instance variables in partials views
  • ⚠️ - Line 187 - Avoid using instance variables in partials views
  • ⚠️ - Line 187 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 187 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 194 - Do not use inline style attributes
  • ⚠️ - Line 194 - id attribute must be in lisp-case
  • ⚠️ - Line 199 - Do not use inline style attributes
  • ⚠️ - Line 200 - Avoid using instance variables in partials views
  • ⚠️ - Line 202 - Avoid using instance variables in partials views
  • ⚠️ - Line 202 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 202 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 209 - Do not use inline style attributes
  • ⚠️ - Line 209 - id attribute must be in lisp-case

app/views/catalog/_provision_entry_points.html.haml

  • ⚠️ - Line 10 - Line is too long. [191/160]
  • ⚠️ - Line 12 - Avoid using instance variables in partials views
  • ⚠️ - Line 12 - Do not use inline style attributes
  • ⚠️ - Line 14 - Avoid using instance variables in partials views
  • ⚠️ - Line 14 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 14 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 19 - id attribute must be in lisp-case
  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Avoid using instance variables in partials views
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 29 - Do not use inline style attributes
  • ⚠️ - Line 2 - Avoid using instance variables in partials views
  • ⚠️ - Line 2 - Style/RedundantInterpolation: Prefer to_s over string interpolation.
  • ⚠️ - Line 5 - Style/CaseLikeIf: Convert if-elsif to case-when.
  • ⚠️ - Line 8 - Layout/SpaceAfterComma: Space missing after comma.
  • ⚠️ - Line 8 - Line is too long. [223/160]

app/views/catalog/_reconfigure_entry_points.html.haml

  • ⚠️ - Line 10 - Line is too long. [195/160]
  • ⚠️ - Line 12 - Avoid using instance variables in partials views
  • ⚠️ - Line 12 - Do not use inline style attributes
  • ⚠️ - Line 14 - Avoid using instance variables in partials views
  • ⚠️ - Line 14 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 14 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 19 - id attribute must be in lisp-case
  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Avoid using instance variables in partials views
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 29 - Do not use inline style attributes
  • ⚠️ - Line 2 - Avoid using instance variables in partials views
  • ⚠️ - Line 2 - Style/RedundantInterpolation: Prefer to_s over string interpolation.
  • ⚠️ - Line 5 - Style/CaseLikeIf: Convert if-elsif to case-when.
  • ⚠️ - Line 7 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
  • ⚠️ - Line 8 - Layout/SpaceAfterComma: Space missing after comma.
  • ⚠️ - Line 8 - Line is too long. [225/160]

app/views/catalog/_retirement_entry_points.html.haml

  • ⚠️ - Line 10 - Line is too long. [185/160]
  • ⚠️ - Line 12 - Avoid using instance variables in partials views
  • ⚠️ - Line 12 - Do not use inline style attributes
  • ⚠️ - Line 14 - Avoid using instance variables in partials views
  • ⚠️ - Line 14 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 14 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 19 - id attribute must be in lisp-case
  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Avoid using instance variables in partials views
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 23 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 29 - Do not use inline style attributes
  • ⚠️ - Line 2 - Avoid using instance variables in partials views
  • ⚠️ - Line 2 - Style/RedundantInterpolation: Prefer to_s over string interpolation.
  • ⚠️ - Line 5 - Style/CaseLikeIf: Convert if-elsif to case-when.
  • ⚠️ - Line 7 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
  • ⚠️ - Line 8 - Layout/SpaceAfterComma: Space missing after comma.
  • ⚠️ - Line 8 - Line is too long. [224/160]

app/views/workflow/show.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - id attribute must be in lisp-case

app/views/workflow/show_list.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - id attribute must be in lisp-case

app/views/workflow_credential/show.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - = "..." should be rewritten as ...

app/views/workflow_credential/show_list.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - = "..." should be rewritten as ...

app/views/workflow_repository/show.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - = "..." should be rewritten as ...

app/views/workflow_repository/show_list.html.haml

  • ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.
  • ⚠️ - Line 1 - = "..." should be rewritten as ...

config/routes.rb

@miq-bot
Copy link
Member

miq-bot commented May 17, 2023

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants