Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Feature Name from native to management_console #8762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidResende0
Copy link
Member

@DavidResende0 DavidResende0 commented Apr 24, 2023

Follow up to: #8758

Changes the feature name for the IBM providers from native_console to management_console since native_console is already used by the RHV provider. Also still resolves the issue the above pr was attempting to fix.

Other PRs:
core -> ManageIQ/manageiq#22474
Lenovo -> ManageIQ/manageiq-providers-lenovo#389
vmware -> ManageIQ/manageiq-providers-vmware#874
ibm_power_hmc -> ManageIQ/manageiq-providers-ibm_power_hmc#136
ibm_terraform -> ManageIQ/manageiq-providers-ibm_terraform#94
ibm_cloud -> ManageIQ/manageiq-providers-ibm_cloud#451
ibm_power_vc -> ManageIQ/manageiq-providers-ibm_power_vc#90

@agrare
Copy link
Member

agrare commented Apr 24, 2023

@DavidResende0 is there a supports? check for the ext_management_system?

@DavidResende0
Copy link
Member Author

@DavidResende0 is there a supports? check for the ext_management_system?

It doesn't seem like there is actually. I'll remove the supports_not there

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like there is actually. I'll remove the supports_not there

Hm no I think we should figure this out and get it working "properly" Please don't merge @jeffibm

@agrare
Copy link
Member

agrare commented Apr 25, 2023

For EMS the button is here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/toolbar/ems_cloud_center.rb#L124-L144 which uses ApplicationHelper::Button::NativeConsole and that checks supports?(:native_console): https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/native_console.rb#L5

@agrare
Copy link
Member

agrare commented Apr 25, 2023

This looks good, will approve&merge once we have the other providers ext_management_systems updated with the new feature

@jeffibm
Copy link
Member

jeffibm commented Apr 27, 2023

Hey @DavidResende0 , could you rebase with master to fix the failing specs

@jeffibm
Copy link
Member

jeffibm commented Apr 27, 2023

It doesn't seem like there is actually. I'll remove the supports_not there

Hm no I think we should figure this out and get it working "properly" Please don't merge @jeffibm

ok. setting the title to WIP

@jeffibm jeffibm changed the title Changed Feature Name from native to management_console [WIP] Changed Feature Name from native to management_console Apr 27, 2023
@miq-bot miq-bot added the wip label Apr 27, 2023
@DavidResende0 DavidResende0 reopened this Apr 27, 2023
miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jul 13, 2023
@agrare
Copy link
Member

agrare commented Jul 13, 2023

@DavidResende0 cross-repo is still failing on the UI specs can you take a look?

@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2023

Checked commit DavidResende0@cec109c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
9 files checked, 2 offenses detected

app/helpers/application_helper/button/management_console.rb

app/helpers/application_helper/button/vm_management_console.rb

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jul 26, 2023
@DavidResende0 DavidResende0 changed the title [WIP] Changed Feature Name from native to management_console Changed Feature Name from native to management_console Jul 26, 2023
@miq-bot miq-bot removed the wip label Jul 26, 2023
@miq-bot miq-bot added the stale label Oct 30, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@jeffibm
Copy link
Member

jeffibm commented Mar 13, 2024

Hey @DavidResende0 , could you please update the status of this PR when you have time? Thanks.

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Sep 23, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants