Changed Feature Name from native to management_console

[DavidResende0]

Follow up to: #8758

Changes the feature name for the IBM providers from native_console to management_console since native_console is already used by the RHV provider. Also still resolves the issue the above pr was attempting to fix.

Other PRs:
core -> ManageIQ/manageiq#22474
Lenovo -> ManageIQ/manageiq-providers-lenovo#389
vmware -> ManageIQ/manageiq-providers-vmware#874
ibm_power_hmc -> ManageIQ/manageiq-providers-ibm_power_hmc#136
ibm_terraform -> ManageIQ/manageiq-providers-ibm_terraform#94
ibm_cloud -> ManageIQ/manageiq-providers-ibm_cloud#451
ibm_power_vc -> ManageIQ/manageiq-providers-ibm_power_vc#90

[agrare]

@DavidResende0 is there a supports? check for the ext_management_system?

[DavidResende0]

@DavidResende0 is there a supports? check for the ext_management_system?

It doesn't seem like there is actually. I'll remove the supports_not there

[agrare]

It doesn't seem like there is actually. I'll remove the supports_not there

Hm no I think we should figure this out and get it working "properly" Please don't merge @jeffibm

[agrare]

For EMS the button is here: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/toolbar/ems_cloud_center.rb#L124-L144 which uses ApplicationHelper::Button::NativeConsole and that checks supports?(:native_console): https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/native_console.rb#L5

[agrare]

This looks good, will approve&merge once we have the other providers ext_management_systems updated with the new feature

[jeffibm]

Hey @DavidResende0 , could you rebase with master to fix the failing specs

[jeffibm]

It doesn't seem like there is actually. I'll remove the supports_not there

Hm no I think we should figure this out and get it working "properly" Please don't merge @jeffibm

ok. setting the title to WIP

[agrare]

@DavidResende0 have you tested this?
Do these methods have to be updated? https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ems_cloud_controller.rb#L45-L47 and https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ems_infra_controller.rb#L213-L215

[agrare]

@miq-bot cross-repo-tests ManageIQ/manageiq#22474 ManageIQ/manageiq-providers-lenovo#389 ManageIQ/manageiq-providers-vmware#874 ManageIQ/manageiq-providers-ibm_power_hmc#136 ManageIQ/manageiq-providers-ibm_terraform#94 ManageIQ/manageiq-providers-ibm_cloud#451 ManageIQ/manageiq-providers-ibm_power_vc#90

[agrare]

@DavidResende0 cross-repo is still failing on the UI specs can you take a look?

[miq-bot]

Checked commit DavidResende0@cec109c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
9 files checked, 2 offenses detected

app/helpers/application_helper/button/management_console.rb

• ❗ - Line 5, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/helpers/application_helper/button/vm_management_console.rb

• ❗ - Line 5, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

[DavidResende0]

@miq-bot cross-repo-tests ManageIQ/manageiq#22474 ManageIQ/manageiq-providers-lenovo#389 ManageIQ/manageiq-providers-vmware#874 ManageIQ/manageiq-providers-ibm_power_hmc#136 ManageIQ/manageiq-providers-ibm_terraform#94 ManageIQ/manageiq-providers-ibm_cloud#451 ManageIQ/manageiq-providers-ibm_power_vc#90

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[jeffibm]

Hey @DavidResende0 , could you please update the status of this PR when you have time? Thanks.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).