Adding embedded workflows to service catalog item

[jeffibm]

Before

• Provisioning Entry Point is mandatory, has a default value
• Reconfigure Entry Point is optional, and does not have a default value
• Retirement Entry Point is optional, has a default value

After

Service Catalog item

1. Go to Add a new Service Catalog item Form

2. Provision Entry Point, Reconfigure Entry Point, Retirement Entry Point's input changed to Drop down list

3. Drop-down options are Embedded Automate & Embedded Workflows

4. When one item is selected, the corresponding input field appears

5. When you click on the input field, a new modal box appears for embedded workflows. The old modal will appear for embedded automated

6. When we select one of the items in the list, the name appears on the input field of

[Fryguy]

@agrare Please review. While the name appearing seems ok, I think we should be sending the ID number as part of the form.

[agrare]

@jeffibm I'm not sure if you want to handle this in a separate PR, or if there is a way to handle it generically but there is also the entrypoint selection in the Automation / Customization / Service Dialogs / Add a new Dialog area

[agrare]

Hit a bug setting an entrypoint back to No Entry Point

[----] D, [2023-06-07T11:26:18.786726 #439637:63574] DEBUG -- :   Rendered /home/grare/adam/src/manageiq/manageiq-ui-classic/app/views/catalog/_reconfigure_entry_points.html.haml (Duration: 24.6ms | Allocations: 6483)
[----] F, [2023-06-07T11:26:18.786936 #439637:63574] FATAL -- : Error caught: [ActionView::Template::Error] undefined method `[]' for nil:NilClass
/home/grare/adam/src/manageiq/manageiq-ui-classic/app/views/catalog/_reconfigure_entry_points.html.haml:20:in `__home_grare_adam_src_manageiq_manageiq_ui_classic_app_views_catalog__reconfigure_entry_points_html_haml__1085212262945803632_418660'
/home/grare/adam/.gem/ruby/3.0.0/gems/actionview-6.1.7.3/lib/action_view/base.rb:247:in `public_send'
/home/grare/adam/.gem/ruby/3.0.0/gems/actionview-6.1.7.3/lib/action_view/base.rb:247:in `_run'
/home/grare/adam/.gem/ruby/3.0.0/gems/actionview-6.1.7.3/lib/action_view/template.rb:154:in `block in render

[agrare]

Minor, but when you load the form you have No Entry Point with no selection box

Pick one and the selection box shows up

But if you set it back to No Entry Point the selection box isn't cleared (NOTE maybe because of the exception mentioned above?)

But you can still click on the Click to select a provisioning entrypoint button and the workflows list shows up even though No Entry Point is selected.

[agrare]

If I pick a workflows provisioning entrypoint then pick add I get an error that I have to pick a provisioning entrypoing

[agrare]

I think we should be sending the ID number as part of the form.

It isn't obvious to me what we are sending based on the code changes, @jeffibm do you have an example of a ResourceAction that was created based off of one of these selections? I'm not able to get the form to save locally.

But yes in general we should be using the workflow ID since this is what will be set in the ResourceAction#configuration_script_id

[jeffibm]

I think we should be sending the ID number as part of the form.

It isn't obvious to me what we are sending based on the code changes, @jeffibm do you have an example of a ResourceAction that was created based off of one of these selections? I'm not able to get the form to save locally.

But yes in general we should be using the workflow ID since this is what will be set in the ResourceAction#configuration_script_id

I have to save the new values in UI somewhere before the submit action. its in progress...

[jeffibm]

@jeffibm I'm not sure if you want to handle this in a separate PR, or if there is a way to handle it generically but there is also the entrypoint selection in the Automation / Customization / Service Dialogs / Add a new Dialog area

adding the entry points here needs changes in ui-components repository. will link the PR in description

[Fryguy]

@jeffibm Please be sure this is hidden behind the prototype flag.

[jeffibm]

@agrare , I have a PR for ui-components noopurAg/ui-components#3

[jeffibm]

If I pick a workflows provisioning entrypoint then pick add I get an error that I have to pick a provisioning entrypoing

the changed values are being stored somewhere and validated. checking...

[Fryguy]

@agrare , I have a PR for ui-components noopurAg/ui-components#3

@jeffibm I think you made this PR to the wrong repository - this is pointing to @noopurAg 's fork

[jeffibm]

Screen.Recording.2023-06-22.at.5.20.57.PM.mov

[jeffibm]

Screen.Recording.2023-06-30.at.2.44.54.PM.mov

[jeffibm]

Screen.Recording.2023-07-18.at.2.35.23.PM.mov

[agrare]

@jeffibm FYI this conflicts with #8844

[agrare]

This works for me locally manually updating package.json to 1.5.0

[miq-bot]

Checked commit jeffbonson@7b0ddac with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
12 files checked, 87 offenses detected

app/controllers/catalog_controller.rb

• ❗ - Line 1029, Col 7 - Style/Next - Use next to skip iteration.
• ❗ - Line 1313, Col 7 - Style/CaseLikeIf - Convert if-elsif to case-when.

app/helpers/automate_tree_helper.rb

• ❗ - Line 103, Col 24 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 104, Col 32 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 105, Col 13 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 163, Col 7 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 167, Col 7 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 170, Col 7 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 172, Col 7 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 173, Col 7 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 60, Col 16 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 61, Col 24 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 62, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 67, Col 27 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/views/catalog/_embedded_workflows_modal.html.haml

• ⚠️ - Line 1 - Layout/TrailingEmptyLines: Final newline missing.

app/views/catalog/_entry_point_selector.html.haml

• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 3 - Layout/TrailingEmptyLines: Final newline missing.
• ⚠️ - Line 4 - Avoid using instance variables in partials views

app/views/catalog/_form_basic_info.html.haml

• ⚠️ - Line 172 - id attribute must be in lisp-case
• ⚠️ - Line 181 - id attribute must be in lisp-case
• ⚠️ - Line 189 - id attribute must be in lisp-case
• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 20 - Avoid using instance variables in partials views
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 31 - Avoid using instance variables in partials views
• ⚠️ - Line 4 - Layout/TrailingEmptyLines: Final newline missing.
• ⚠️ - Line 4 - id attribute must be in lisp-case

app/views/catalog/_provision_entry_point.html.haml

• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/SpaceAfterComma: Space missing after comma.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
• ⚠️ - Line 16 - id attribute must be in lisp-case
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/TrailingEmptyLines: Final newline missing.

app/views/catalog/_reconfigure_entry_point.html.haml

• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/SpaceAfterComma: Space missing after comma.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
• ⚠️ - Line 16 - id attribute must be in lisp-case
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/TrailingEmptyLines: Final newline missing.

app/views/catalog/_retire_entry_point.html.haml

• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 10 - Layout/SpaceAfterComma: Space missing after comma.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 10 - Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
• ⚠️ - Line 16 - id attribute must be in lisp-case
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 20 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 3 - Layout/TrailingEmptyLines: Final newline missing.

[Fryguy]

@jeffibm A conflict occurred during the backport of this pull request to petrosian.

If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the petrosian branch in order to resolve this.

Conflict details:

diff --cc app/stylesheet/miq-data-table.scss
index 5f231a62be,0c6c4e3bd7..0000000000
--- a/app/stylesheet/miq-data-table.scss
+++ b/app/stylesheet/miq-data-table.scss
@@@ -283,3 -283,73 +283,76 @@@ table.miq_preview 
      width: 135px;
    }
  }
++<<<<<<< HEAD
++=======
+ 
+ .reconfigure-add-button {
+   margin-bottom: 10px;
+ }
+ 
+ .disk-table {
+   .bx--form-item{
+     margin-bottom: 0px !important;
+   }
+ }
+ 
+ .header-button {
+   width: 100px !important;
+ }
+ 
+ .reconfigure-form {
+   .disk-table-list {
+     .bx--table-header-label {
+       white-space: normal !important;
+     }
+   }
+   .bx--btn--ghost:hover, .bx--btn--ghost:active{
+     background-color: transparent !important;
+   }
+   .bx--btn--ghost:focus {
+     border-color: transparent !important;
+     box-shadow: none !important;
+   }
+   .bx--btn--ghost span {
+     min-width: 50px !important;
+   }
+ }
+ .catalogs_form {
+ 
+   input[type="text"] {
+     width: 220px;
+   }
+ 
+   .no-padding{
+     padding: 0;
+   }
+ 
+   .long_text {
+     width: 100% !important;
+   }
+ 
+   .entry_point_selector {
+     padding: 3px;
+ 
+     .entry_point_text, .entry_point_button {
+       border-right: 0;
+     }
+ 
+     span.input-group-addon{
+       visibility: hidden;
+     }
+   }
+   .workflow_modal_wrapper {
+     min-height: 26px;
+     display: flex;
+     align-items: center;
+   }
+   
+   .workflows-entry-point-modal-body {
+     .miq-data-table {
+       margin-top: 0px;
+     }
+   }
+ }
+ 
++>>>>>>> 0e07a1d9ec (Merge pull request #8815 from jeffibm/add-workflows-to-catalogs)

[jeffibm]

@Fryguy , the css changes are coming in from this PR - Angular to react conversion Reconfigure form #8710

[Fryguy]

I don't think we are going to backport that file, so you will need to create a direct-to-petrosian backport PR

[Fryguy]

Backported to petrosian via #8873