Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explorer title width #9290

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

GilbertCherrie
Copy link
Member

Fixed the explorer title width to use 100% of the width of the row component.

Before:
Screenshot 2024-10-18 at 1 18 13 PM

After:
Screenshot 2024-10-18 at 1 15 21 PM

@Fryguy
Copy link
Member

Fryguy commented Oct 18, 2024

Do you have screenshots where there are other objects next to the title - I'm thinking like some of the summary pages where we can do search or advanced filtering?

@GilbertCherrie
Copy link
Member Author

Do you have screenshots where there are other objects next to the title - I'm thinking like some of the summary pages where we can do search or advanced filtering?

Oh yeah I see, this pr breaks those titles. Will change this to WIP until that is fixed.

@GilbertCherrie GilbertCherrie changed the title Fix explorer title width [WIP] Fix explorer title width Oct 18, 2024
@GilbertCherrie GilbertCherrie force-pushed the fix_explorer_title_width branch 3 times, most recently from dcedd60 to cc85cc2 Compare October 28, 2024 17:57
@GilbertCherrie
Copy link
Member Author

@Fryguy the issue with the search bar has been fixed if you can review this pr again when you have time

@GilbertCherrie GilbertCherrie changed the title [WIP] Fix explorer title width Fix explorer title width Oct 28, 2024
@Fryguy Fryguy merged commit 6771183 into ManageIQ:master Oct 29, 2024
15 checks passed
@GilbertCherrie GilbertCherrie deleted the fix_explorer_title_width branch October 29, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants