Fix bin/webpack when ui-classic not bundled #9293
Conversation
When building rpms, we do not run bundle update in ui-classic (we only run in core) To build the ui assets, we use `rake update:ui` which calls `./bin/webpack`. The webpack command needs to know the i18n gem, and asks bundler for that path. Since bundler has not been installed, this command fails. The solution is to populate the i18n path in our paths.json file. Since this path was known when we created paths.json, this is easier to do. Before ====== So when running bin/webpack, we get an error when running `bundle info`: ``` ./bin/webpack Ruby versions >= 3.2.0 are untested! The git source https://github.com/ManageIQ/amazon_ssa_support.git is not yet checked out. Please run `bundle install` before trying to start your application manageiq-ui-classic/node_modules/webpack-cli/bin/cli.js:93 throw err; ``` After ===== ``` ./bin/webpack [success] ```
|
update:
|
bin/webpack
Outdated
| # flag anymore. | ||
| has_legacy_openssl = system('node --help | grep -qs "\\--openssl-legacy-provider"') | ||
| `node --openssl-legacy-provider --openssl-legacy-provider -v` |
There was a problem hiding this comment.
Not that the check here is because not all compilations of node have this option. If you try to call node when the option doesn't exist it blows up.
There was a problem hiding this comment.
sorry, added to slack but not here. Will copy here since that is where it belongs.
The old node --help | grep was actually the issue around node pipes. It was failing sporadically. But couldn't nail down why. I could get the command to fail on a bash prompt - so I'm sure this is the issue.
I just put that in so it will fail if is not available and we are looking at $?
I'll fix the typo for double typing the --openssl-legacy-provider
I liked the old code outputting when there were issues.
I could look for other ways to determine if ssl legacy was necessary
Before ====== For some reason, our old method was sporadic ``` node --help | grep -qs "\\--openssl-legacy-provider" ``` node help was throwing a socket close error every few runs locally After ===== We are running node a new way that does not throw an exception. We changed over to back ticks to hide the output from the command But the $? is updated with the status of the system call and we determine success
When building rpms, we do not run bundle update in ui-classic (we only run in core)
To build the ui assets, we use
rake update:uiwhich calls./bin/webpack.The webpack command needs to know the i18n gem, and asks bundler for that path.
Since bundler has not been installed, this command fails.
The solution is to populate the i18n path in our paths.json file.
Since this path was known when we created paths.json, this is easier to do.
Before
So when running bin/webpack, we get an error when running
bundle info:After