Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bin/webpack when ui-classic not bundled #9293

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix bin/webpack when ui-classic not bundled #9293

merged 2 commits into from
Oct 22, 2024

Commits on Oct 21, 2024

  1. Fix bin/webpack when ui-classic not bundled 

    When building rpms, we do not run bundle update in ui-classic (we only run in core)

To build the ui assets, we use `rake update:ui` which calls `./bin/webpack`.
The webpack command needs to know the i18n gem, and asks bundler for that path.
Since bundler has not been installed, this command fails.

The solution is to populate the i18n path in our paths.json file.
Since this path was known when we created paths.json, this is easier to do.

Before
======

So when running bin/webpack, we get an error when running `bundle info`:

```
./bin/webpack

Ruby versions >= 3.2.0 are untested!
The git source https://github.com/ManageIQ/amazon_ssa_support.git is not yet
checked out. Please run `bundle install` before trying to start your application
manageiq-ui-classic/node_modules/webpack-cli/bin/cli.js:93
				throw err;
```

After
=====

```
./bin/webpack

[success]
```
    @kbrock
    kbrock committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f2fc155 View commit details
    Browse the repository at this point in the history

  2. update how we determine ssl is available 

    Before
======

For some reason, our old method was sporadic

```
node --help | grep -qs "\\--openssl-legacy-provider"
```

node help was throwing a socket close error every few runs locally

After
=====

We are running node a new way that does not throw an exception.
We changed over to back ticks to hide the output from the command
But the $? is updated with the status of the system call and we determine success
    @kbrock
    kbrock committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    13b2d67 View commit details
    Browse the repository at this point in the history