-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing embedded_workflow to dynamic select box in service dialogs #471
Conversation
EDIT: Builds are working now after #473 |
<div pf-form-group pf-label="Automation Type" class="entry_point_selector_types"> | ||
<select class="form-control" miq-select ng-model="vm.modalData.automation_type" ng-change="vm.treeOptions.onAutomationTypeChange()"> | ||
<option value="{{vm.treeOptions.automationTypes.automate}}" translate>Embedded Automate</option> | ||
<option value="{{vm.treeOptions.automationTypes.workflow}}" translate>Embedded Workflows</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should only show this if the prototype flag is enabled. This can be found via API.
b17ac1e
to
e43627c
Compare
3dadda5
to
ed21527
Compare
Checked commit jeffbonson@ed21527 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
@DavidResende0 or @GilbertCherrie could you review this as well? |
Screenshots in related PR - ManageIQ/manageiq-ui-classic#8844