Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skill Icon/Description + onSkillMastered #20

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Skill Icon/Description + onSkillMastered #20

merged 3 commits into from
Dec 2, 2023

Conversation

minheragon12345
Copy link
Collaborator

@minheragon12345 minheragon12345 commented Dec 2, 2023 •
edited
Loading

Description

Skill Icon/Description adn onSkillMastered method.

List of changes

  • Skill Icon.
  • Skill Description.
  • onSkillMastered()

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Refactoring (non-breaking change which improved the Code Quality)
  • Breaking Code Refactoring (breaking change which improved the Code Quality)
  • Documentation update (JavaDoc or Markdown change)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Charismara Charismara merged commit 718889d into 1.19.2/master Dec 2, 2023
3 of 5 checks passed
@Charismara Charismara deleted the dev/minh_cool branch December 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charismara Charismara Charismara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minheragon12345 @Charismara