Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Held Attributes added. #33

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Held Attributes added. #33

merged 4 commits into from
Apr 24, 2024

Conversation

minheragon12345
Copy link
Collaborator

@minheragon12345 minheragon12345 commented Apr 24, 2024 •
edited
Loading

Description

Attribute Modifiers when holding skills.

List of changes

  • addHeldAttributeModifier
  • addHeldAttributeModifiers
  • removeHeldAttributeModifiers

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Refactoring (non-breaking change which improved the Code Quality)
  • Breaking Code Refactoring (breaking change which improved the Code Quality)
  • Documentation update (JavaDoc or Markdown change)

@minheragon12345 minheragon12345 self-assigned this Apr 24, 2024
Charismara
Charismara requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Charismara Charismara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try the vanilla system first

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Charismara Charismara merged commit 4b73b35 into 1.19.2/master Apr 24, 2024
2 of 3 checks passed
@Charismara Charismara deleted the 1.19.2/minh branch April 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charismara Charismara Charismara approved these changes

Assignees

@minheragon12345 minheragon12345

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minheragon12345 @Charismara