ManasCore port to 1.21 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most significant change is the usage of Holder for Attributes and ResourceLocation instead of UUIDs
TODO: Find better way to get Holder instance of Attribute. Currently, I can't cast the RangedAttribute Holder to an Attribute Holder, because they're not the same type due to generics. Therefore, I created a Direct Holder.
TODO: Find better way to get Holder instance of Attribute. Currently, I can't cast the RangedAttribute Holder to an Attribute Holder, because they're not the same type due to generics. Therefore, I created a Direct Holder.
…methods. For ResourceLocation, the new ResourceLocation#fromNamespaceAndPath For Attributes, the Holder#direct method
TODO: Find out what happened to EnchanementHelper#getSweepingDamageRatio
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ports ManasCore to 1.21
With this update, a lot of stuff got changed, especially how ResourceLocations are created and the way you access Registry Entries.
Furthermore, some methods have been removed and shuffled around.
Look at the commits for further explanations. Each commit has a detailed description of why it changed.
List of changes
Type of Change