Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when logging is enabled #249

Closed
kaderate opened this issue Apr 2, 2024 · 1 comment · Fixed by #250
Closed

Improve error handling when logging is enabled #249

kaderate opened this issue Apr 2, 2024 · 1 comment · Fixed by #250

Comments

@kaderate
Copy link

kaderate commented Apr 2, 2024

When logging is enabled and an API call fail with another exception that Net::ReadTimeout, the following exception is raised:

NoMethodError: undefined method '*' for nil (NoMethodError) line += "\n [#{(time * 1000).round(1)}ms] 408 Request Timeout #{params}\n" ^

The cause is the time parameter here is not initialized properly and can nil in the case described above:

res, time = nil, nil

@fredericdelordm
Copy link

Hello @kaderate, thanks for the feedback. We are looking into it.

@iulian03 iulian03 linked a pull request Apr 10, 2024 that will close this issue
iulian03 added a commit that referenced this issue Apr 10, 2024
…rror-handling

improved error handling and updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants