Allow to configure use_ssl option #225
Merged
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantaskujalis
force-pushed
the
feature/configurable_use_ssl
branch
2 times, most recently
from
727a312
to
1f05465
Compare
mantaskujalis
force-pushed
the
feature/configurable_use_ssl
branch
from
1f05465
to
2b0622c
Compare
|
@iulian03 maybe you had time to look into this? |
|
@iulian03 any chance someone could look into these changes? Would really appreciate |
|
@mantaskujalis @vikt3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
we are trying to configure our testing environment and got stuck on forced
use_ssloption as mandatory. As specs runs only locally (via docker) we are having hard time getting ssl certificate.This PR allows to configure
use_ssloption in preproduction enviroment. Production would be left unconfigurable as I believe ssl forcing is good thing in production.In
preproductionenv without settinguse_ssloption it would also default totrueunless value is explicitly assigned tofalse@iulian03