Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 basic linting rule e #233

Merged
merged 4 commits into from
Jun 18, 2024
Merged

230 basic linting rule e #233

merged 4 commits into from
Jun 18, 2024

Conversation

mschwoer
Copy link
Collaborator

  • Add ruff linting to pre-commit
  • add rule "E" to ruleset
  • make code pass rule "E" (see individual commits)

@mschwoer mschwoer requested a review from GeorgWa June 17, 2024 18:41
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jun 18, 2024
GeorgWa
GeorgWa approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should not cause any issues

alphadia/plexscoring.py Show resolved Hide resolved
Base automatically changed from 230-basic-linting to development June 18, 2024 07:21
@mschwoer mschwoer merged commit 6bf987e into development Jun 18, 2024
6 checks passed
@mschwoer mschwoer deleted the 230-basic-linting-rule-e branch June 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa