Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230 basic linting rule sim #238

Merged
merged 14 commits into from
Jun 19, 2024
Merged

230 basic linting rule sim #238

merged 14 commits into from
Jun 19, 2024

Conversation

mschwoer
Copy link
Collaborator

  • add rule "SIM" to ruleset
  • make code pass rule "SIM" (see individual commits)

@mschwoer mschwoer requested a review from GeorgWa June 19, 2024 08:58
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/plexscoring.py Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Show resolved Hide resolved
release/pyinstaller/cli_hook.py Outdated Show resolved Hide resolved
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jun 19, 2024
Base automatically changed from 230-basic-linting-rule-up to development June 19, 2024 14:58
@mschwoer mschwoer merged commit 1b63257 into development Jun 19, 2024
4 checks passed
@mschwoer mschwoer deleted the 230-basic-linting-rule-sim branch June 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants