Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dynamic optimization lock #309

Merged
merged 20 commits into from
Aug 21, 2024
Merged

Conversation

odespard
Copy link
Collaborator

Allows optimization lock increase and decrease in size, which prevents crashing if the number of precursors detected decreases markedly. Also encapsulates optimization lock-related functions in a new class.

@odespard odespard added the test:e2e End to end tests will be run on PRs that carry this label. label Aug 16, 2024
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 16, 2024
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 20, 2024
alphadia/outputtransform.py Show resolved Hide resolved
alphadia/outputtransform.py Show resolved Hide resolved
alphadia/outputtransform.py Outdated Show resolved Hide resolved
alphadia/workflow/manager.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 20, 2024
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 21, 2024
@odespard odespard added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Aug 21, 2024
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odespard odespard merged commit 5dc9ac9 into development Aug 21, 2024
10 checks passed
@odespard odespard deleted the new_dynamic_optimization_lock branch August 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants