Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrate relevant subset in dynamic lock #317

Merged
merged 15 commits into from
Aug 22, 2024

Conversation

odespard
Copy link
Collaborator

Only recalibrating the relevant parts of the library speeds up optimization and calibration markedly.

Base automatically changed from new_dynamic_lock_rt_proportion to new_dynamic_optimization_lock August 21, 2024 09:16
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
Base automatically changed from new_dynamic_optimization_lock to development August 21, 2024 21:08
@odespard odespard added the test:e2e End to end tests will be run on PRs that carry this label. label Aug 22, 2024
@odespard odespard requested a review from mschwoer August 22, 2024 09:52
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very readable and modular, LGTM

alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
tests/unit_tests/test_workflow.py Show resolved Hide resolved
@odespard odespard merged commit b53173e into development Aug 22, 2024
5 checks passed
@odespard odespard deleted the new_dynamic_lock_with_subset_calibrated branch August 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants