Refactor convergence rules #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
additional_convergence_criterion
to
development
August 30, 2024 08:01
mschwoer
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates convergence rules to keep current functionality but allow them also work with negative values (useful in principle if we want to use a feature which reaches a minimum at the desired optimum -- we can just maximize the negative) and cope if parameter values increase during optimization (which is unusual but can happen). Also splits the behaviour currently activated by favour_narrower_parameter in two: continuing until a significant decrease is enabled now by try_narrower_values in the calibration field, while choosing the narrowest parameter within a certain deviation from the maximum is enabled by favour_narrower_optimum in the calibration field.