Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG optimization lock, fix #347 #348

Merged
merged 4 commits into from
Sep 16, 2024
Merged

BUG optimization lock, fix #347 #348

merged 4 commits into from
Sep 16, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Sep 14, 2024

  • light refactoring
  • fix bug where the optimization lock should be optimized

odespard
odespard approved these changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@odespard odespard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible.

alphadia/workflow/optimization.py Outdated Show resolved Hide resolved
@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Sep 15, 2024
mschwoer
mschwoer approved these changes Sep 16, 2024
View reviewed changes
alphadia/workflow/optimization.py Show resolved Hide resolved
@GeorgWa GeorgWa changed the base branch from main to development September 16, 2024 11:10
@GeorgWa GeorgWa merged commit e407c3c into development Sep 16, 2024
4 of 28 checks passed
@GeorgWa GeorgWa deleted the fix-optlock branch September 16, 2024 11:11
@GeorgWa GeorgWa added the bug Something isn't working label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@odespard odespard odespard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgWa @odespard @mschwoer