Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI code refactoring up to analysis #304

Merged
merged 21 commits into from
Sep 6, 2024
Merged

Conversation

JuliaS92
Copy link
Collaborator

@JuliaS92 JuliaS92 commented Sep 5, 2024

  • move most functions from pages to helper utils
  • move software options to options
  • turn options into functions as they depend on the session state
  • add sidebar info to all pages
  • remove the load options decorator
  • comment out interpreter options as they don't exist

These changes facilitate testing of the indivudal functions and separating ui logic and design for callbacks.

I didn't do any file renaming to avoid merge conflicts as I saw that other branches had already done this.

Copy link
Contributor

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphastats/gui/utils/analysis_helper.py Show resolved Hide resolved
alphastats/gui/utils/options.py Outdated Show resolved Hide resolved
alphastats/gui/utils/options.py Show resolved Hide resolved
@JuliaS92 JuliaS92 merged commit 42e6a32 into development Sep 6, 2024
4 checks passed
@JuliaS92 JuliaS92 deleted the ui_code_refactoring branch September 6, 2024 12:05
@JuliaS92 JuliaS92 restored the ui_code_refactoring branch September 6, 2024 12:05
@mschwoer mschwoer deleted the ui_code_refactoring branch September 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants