Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client.py BO to TOOLBOX #81

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Update client.py BO to TOOLBOX #81

merged 4 commits into from
Jul 10, 2024

Conversation

juanjogarciatorres43
Copy link
Contributor

No description provided.

@juanjogarciatorres43 juanjogarciatorres43 self-assigned this Jul 8, 2024
GabDug
GabDug requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@GabDug GabDug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments to address and it an be merged :)

src/firefighter/firefighter/settings/components/raid.py Outdated Show resolved Hide resolved
src/firefighter/raid/client.py Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@GabDug GabDug mentioned this pull request Jul 10, 2024
Closed
@GabDug GabDug merged commit b4d4c81 into main Jul 10, 2024
4 checks passed
@GabDug GabDug deleted the BO_to_TOOLBOX branch July 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabDug GabDug GabDug approved these changes

Assignees

@juanjogarciatorres43 juanjogarciatorres43

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanjogarciatorres43 @GabDug