Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): edit command to update the metadata of an incident #96

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

jennafauconnier
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 62.63%. Comparing base (7fbaea4) to head (ccd7cf2).

Files with missing lines Patch % Lines
.../templates/layouts/partials/incident_timeline.html 0.00% 31 Missing ⚠️
src/firefighter/slack/views/modals/edit.py 50.00% 19 Missing and 1 partial ⚠️
src/firefighter/slack/messages/slack_messages.py 0.00% 9 Missing ⚠️
src/firefighter/incidents/models/incident.py 60.00% 2 Missing ⚠️
src/firefighter/slack/views/events/commands.py 0.00% 2 Missing ⚠️
src/firefighter/incidents/forms/edit.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   62.80%   62.63%   -0.17%     
==========================================
  Files         213      215       +2     
  Lines        9431     9522      +91     
  Branches     1276     1288      +12     
==========================================
+ Hits         5923     5964      +41     
- Misses       3300     3349      +49     
- Partials      208      209       +1     
Flag Coverage Δ
unittests 62.63% <35.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug GabDug changed the title Add edit command to update the meta of an incident feat(slack): edit command to update the metadata of an incident Sep 27, 2024
@GabDug GabDug merged commit 2f3bfc6 into main Sep 27, 2024
4 checks passed
@GabDug GabDug deleted the feature/update-incidents-details branch September 27, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants