-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mini-benchmark to use constant transactions #3514
Conversation
|
790fbd3
to
bb90f0a
Compare
Hi @robinnewhouse, In general this looks good, I'm not sure about 10.11 for it. This is because it is a behaviour change and that script is installed as part of packages. |
True, but I would call this undesirable behaviour since it gives confusing results as is. But true, it is a change in behaviour so I'm happy to rebase to main. |
bb90f0a
to
f37e4be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you please rebase on latest 'main' so we can see if CI passed and this can be merged? |
Thanks for approving Otto. This is currently based on the latest |
Mini-benchmark was using total time instead of total transactions (events) to measure performance. This could give inconsistent results, particulary when used to count CPU cycles. This changes the sysbench command to use events x threads in each benchmark job, making the benchmark more informative. When `perf` [1] is available and enabled, mini-benchmark will measure how many CPU cycles are required to do a fixed amount of work/queries. If `perf` is unavailable, mini-benchmark will measure the peak queries per second (QPS) during the execution of this work, regardless of the duration. [1] https://perf.wiki.kernel.org
f37e4be
to
4af583d
Compare
Description
Mini-benchmark was using total time instead of total transactions
(events) to measure performance. This could give inconsistent results,
particulary when used to count CPU cycles. This changes the sysbench
command to use events x threads in each benchmark job, making the
benchmark more informative.
When
perf
[1] is available and enabled, mini-benchmark will measure howmany CPU cycles are required to do a fixed amount of work/queries. If
perf
is unavailable, mini-benchmark will measure the peak queries persecond (QPS) during the execution of this work, regardless of the
duration.
[1] https://perf.wiki.kernel.org
Release Notes
No release notes necessary.
How can this PR be tested?
Testing is done in GitLab CI. A passing example can be seen at https://salsa.debian.org/robinnewhouse/mariadb-server-mirror/-/pipelines.
Basing the PR against the correct MariaDB version
PR quality check