Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hide_all and unhide_all options #12

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

elchininet
Copy link
Collaborator

@elchininet elchininet commented Jan 10, 2024

This pull request implements two more options for the configuration:

hide_history_logbook

Hides both, history and logbook in the matched entities.

custom_more_info:
  hide_history_logbook:
    by_entity_id:
      ...
    by_domain:
      ...
    by_device_class:
      ...
    by_glob:
      ...

unhide_history_logbook

Un-hides both, history and logbook in the matched entities.

custom_more_info:
  unhide_history_logbook:
    by_entity_id:
      ...
    by_domain:
      ...
    by_device_class:
      ...
    by_glob:
      ...

@Mariusthvdb
Copy link
Owner

Mariusthvdb commented Jan 11, 2024

working beautifully. nice to have such a powerful 'global' option and combining that with the auto_hide_header_history_icon: true option is really cool.

only thing that I wondered about while setting it up in the yaml was the name.

un/hide_all might be not succinct enough, and, might also give the impression it is about the attributes.... I had to look carefully to place it in the correct logical spot.

maybe we should rename it? it can be a bit longer, as it would only be required twice, and not cause yaml clutter.

un/hide_history_logbook ? would be nice next to
un/hide_history
un/hide_logbook

Let me know what you think ?

@elchininet
Copy link
Collaborator Author

Hi @Mariusthvdb,
Renamed both options following your proposal.
Regards

Copy link
Owner

@Mariusthvdb Mariusthvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working.

much better in the yaml to see what we're doing now.
thx

@Mariusthvdb
Copy link
Owner

go ahead and merge please. all good for now

@elchininet elchininet merged commit c84010c into main Jan 13, 2024
2 checks passed
@elchininet elchininet deleted the implement_hide_all_unhide_all branch January 13, 2024 20:35
@Mariusthvdb
Copy link
Owner

can you prep the release for this too? Would be nice to get this out in the open asap.

@elchininet
Copy link
Collaborator Author

Hey @Mariusthvdb,

Check that this is enabled and I can try to submit an automatic release:

image

Maybe you would need to desprotect the branch, but let‘s try it first with the default protection.

@Mariusthvdb
Copy link
Owner

It is set like that

@elchininet
Copy link
Collaborator Author

The same as the other day:

image

But now thinking about it, I think that if you create a tag manually using the UI, it will create a relase after that, try to do it.

@Mariusthvdb
Copy link
Owner

Mariusthvdb commented Jan 14, 2024

yes, I can do that, but I always need to attach the binary manually.

so not very automatic at all, (only can auto create release notes)

Ill lift the protection for now, and hope you can then auto release?
please check, ive removed most of the ticks...

@elchininet
Copy link
Collaborator Author

elchininet commented Jan 14, 2024

yes, I can do that, but I always need to attach the binary manually.
so not very automatic at all, (only can auto create release notes)

Try to create a tag, everything should happen automatically (at the end what I do in local is to create a tag and push it to the repo).

This action creates the release attaching the binary to it:

- name: Create a release
uses: softprops/action-gh-release@v1
with:
files: |
custom-more-info.js
body: |
${{ steps.build_changelog.outputs.changelog }}

@elchininet
Copy link
Collaborator Author

Ill lift the protection for now, and hope you can then auto release?
please check, ive removed most of the ticks...

Try to create the tag first to see if it works, if not I will push the tag to the repo.

@Mariusthvdb
Copy link
Owner

I've made the 1.1.0 draft.

now what do I do?

@elchininet
Copy link
Collaborator Author

I've made the 1.1.0 draft.

I meaned just a tag not a release, but now I am seeing that it doesn‘t exist in the UI 😕
Incredible that Github doesn‘t have in the UI something so basic.

https://github.com/orgs/community/discussions/48462

No worries, I‘ll push the tag to the repo

@elchininet
Copy link
Collaborator Author

I am having issues to make it, I need to detect what is wrong in the scripts. Give me some time.

@Mariusthvdb
Copy link
Owner

sure, take all the time you need, I am truly grateful for all of your efforts ..

@elchininet
Copy link
Collaborator Author

For some reason all the text from the first release is gone 😕
When the new release is created add some text to it.

elchininet pushed a commit that referenced this pull request Jan 14, 2024
@elchininet
Copy link
Collaborator Author

For some reason the changelog fails, it seems because the previous release was a manual one it cannot retrieve changes taking into account the previous tag. Please, fill the details by hand, I hope that the next one goes well.

You can protect the branch again.

image

@elchininet
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants