-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hide_all and unhide_all options #12
Conversation
48342b4
to
1fa8371
Compare
working beautifully. nice to have such a powerful 'global' option and combining that with the only thing that I wondered about while setting it up in the yaml was the name.
maybe we should rename it? it can be a bit longer, as it would only be required twice, and not cause yaml clutter.
Let me know what you think ? |
Hi @Mariusthvdb, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and working.
much better in the yaml to see what we're doing now.
thx
go ahead and merge please. all good for now |
can you prep the release for this too? Would be nice to get this out in the open asap. |
Hey @Mariusthvdb, Check that this is enabled and I can try to submit an automatic release: Maybe you would need to desprotect the branch, but let‘s try it first with the default protection. |
It is set like that |
yes, I can do that, but I always need to attach the binary manually. so not very automatic at all, (only can auto create release notes) Ill lift the protection for now, and hope you can then auto release? |
Try to create a tag, everything should happen automatically (at the end what I do in local is to create a tag and push it to the repo). This action creates the release attaching the binary to it: custom-more-info/.github/workflows/release.yaml Lines 70 to 76 in c84010c
|
Try to create the tag first to see if it works, if not I will push the tag to the repo. |
I've made the 1.1.0 draft. now what do I do? |
I meaned just a tag not a release, but now I am seeing that it doesn‘t exist in the UI 😕 https://github.com/orgs/community/discussions/48462 No worries, I‘ll push the tag to the repo |
I am having issues to make it, I need to detect what is wrong in the scripts. Give me some time. |
sure, take all the time you need, I am truly grateful for all of your efforts .. |
For some reason all the text from the first release is gone 😕 |
I get what is happening, the tag |
This pull request implements two more options for the configuration:
hide_history_logbook
Hides both, history and logbook in the matched entities.
unhide_history_logbook
Un-hides both, history and logbook in the matched entities.