updated

appupdate/src/main/java/com/marsad/appupdate/AppUpdateFileProvider.java

@@ -3,4 +3,5 @@
 import androidx.core.content.FileProvider;
 
 public class AppUpdateFileProvider extends FileProvider {
+
 }

appupdate/src/main/java/com/marsad/appupdate/dialogs/DownloadDialog.java

@@ -48,6 +48,21 @@ public class DownloadDialog extends DialogFragment implements View.OnClickListen
     private TextView mPercentage, mDownloadTitle;
     private ProgressBar mProgressBar;
     private DownLoadService mDownLoadService;
+    private final ServiceConnection mConnection = new ServiceConnection() {
+        @Override
+        public void onServiceConnected(ComponentName name, IBinder service) {
+            DownLoadService.DownLoadBinder binder = (DownLoadService.DownLoadBinder) service;
+            mDownLoadService = binder.getService();
+            mDownLoadService.registerProgressListener(mProgressListener);
+            mDownLoadService.startDownLoad(mDownloadUrl);
+            mDownLoadService.setNotificationIcon(notificationIcon);
+        }
+
+        @Override
+        public void onServiceDisconnected(ComponentName name) {
+            mDownLoadService = null;
+        }
+    };
     private boolean mMustUpdate;
     private boolean mIsShowBackgroundDownload;
     private OnFragmentOperation mOnFragmentOperation;
@@ -66,7 +81,7 @@ public void handleMessage(Message msg) {
                                 Formatter.formatFileSize(getActivity().getApplication(), contentLength)));
 
                         mPercentage.setText(
-                                String.format(getResources().getString(R.string.update_lib_file_percentage), (((bytesRead/1024) * 100) / (contentLength / 1024))
+                                String.format(getResources().getString(R.string.update_lib_file_percentage), (((bytesRead / 1024) * 100) / (contentLength / 1024))
                                 ));
 
 
@@ -124,21 +139,6 @@ public void onError() {
             mHandler.sendEmptyMessage(ERROR);
         }
     };
-    private final ServiceConnection mConnection = new ServiceConnection() {
-        @Override
-        public void onServiceConnected(ComponentName name, IBinder service) {
-            DownLoadService.DownLoadBinder binder = (DownLoadService.DownLoadBinder) service;
-            mDownLoadService = binder.getService();
-            mDownLoadService.registerProgressListener(mProgressListener);
-            mDownLoadService.startDownLoad(mDownloadUrl);
-            mDownLoadService.setNotificationIcon(notificationIcon);
-        }
-
-        @Override
-        public void onServiceDisconnected(ComponentName name) {
-            mDownLoadService = null;
-        }
-    };
 
     public static DownloadDialog newInstance(String downLoadUrl, int notificationIcon) {
         Bundle args = new Bundle();
@@ -214,8 +214,6 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
         }
 
         mDownloadTitle.setText(mDownloadTitleText);
-
-
     }
 
     @Override
@@ -245,13 +243,16 @@ public void onClick(View view) {
 
     @Override
     public void onDestroy() {
+        if (getActivity() != null)
+            getActivity().unbindService(mConnection);
         super.onDestroy();
-        getActivity().unbindService(mConnection);
+
     }
 
     private void doCancel() {
         mDownLoadService.cancel();
-        getActivity().finish();
+        if (getActivity() != null)
+            getActivity().finish();
         ToastUtils.show(getActivity(), R.string.update_lib_download_cancel);
     }
 

appupdate/src/main/java/com/marsad/appupdate/services/CheckUpdateTask.java

@@ -25,7 +25,7 @@ public class CheckUpdateTask extends Thread {
 
     private static final String TAG = "CheckUpdateTask";
 
-    private Context mContext;
+    private final Context mContext;
     private Callback mCallBack;
     private String mCheckUpdateUrl;
     private Boolean mIsPost;

appupdate/src/main/java/com/marsad/appupdate/services/DownLoadService.java

@@ -39,7 +39,6 @@ public void onCreate() {
             mNotificationManager.createNotificationChannel(channel);
         }
 
-
     }
 
     public void startDownLoad(String url) {

appupdate/src/main/java/com/marsad/appupdate/services/DownloadTask.java

@@ -41,12 +41,12 @@ public void run() {
             in = new BufferedInputStream(connection.getInputStream());
             int count = connection.getContentLength();
             if (count <= 0) {
-                Log.e(TAG, "file length must > 0");
+                Log.e(TAG, "file length must be > 0");
                 return;
             }
 
             if (in == null) {
-                Log.e(TAG, "InputStream not be null");
+                Log.e(TAG, "InputStream can not be null");
                 return;
             }