Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rounding when formatTextValue callback is set #89

Open
victor-timofei opened this issue Nov 11, 2021 · 2 comments
Open

Remove the rounding when formatTextValue callback is set #89

victor-timofei opened this issue Nov 11, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@victor-timofei
Copy link

I think the the floatNumber should not be called at

? formatTextValue(floatingNumber(percentage))
and leave the option to the user to round it however he wants with formatTextValue.

@bjbrewster
Copy link

I agree. I'm working on cleaning this project up and will change this to accept original value. I would prefer to change formatTextValue property to text property that accepts string value instead of function as you should already have percentage value you've passed to the component available. I myself am showing the raw value with units before converted to percentage so the function is even more useless to me. Thoughts @Martin36 ?

@Martin36 Martin36 added the help wanted Extra attention is needed label Aug 17, 2022
@Martin36
Copy link
Owner

Martin36 commented Sep 3, 2022

I agree. I'm working on cleaning this project up and will change this to accept original value. I would prefer to change formatTextValue property to text property that accepts string value instead of function as you should already have percentage value you've passed to the component available. I myself am showing the raw value with units before converted to percentage so the function is even more useless to me. Thoughts @Martin36 ?

I think that sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants