Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Pull Request Template #5

Open
bonimy opened this issue Aug 22, 2017 · 0 comments
Open

Create a Pull Request Template #5

bonimy opened this issue Aug 22, 2017 · 0 comments

Comments

@bonimy
Copy link
Collaborator

bonimy commented Aug 22, 2017

Issue

The project currently does not have a PULL_REQUEST_TEMPLATE.md file

Features

A PULL_REQUEST_TEMPLATE.md allows our contributors to describe the features of their pull request in a standardized way. Refer to GitHub's mention on the subject for more information on why this is helpful.

Resolution

This repo seems to have a good list of templates to select from. It may be a good idea to just take one of theirs if any seem fitting.

Possible things to mention/check off:

  • Are the commit messages formatted according to the CONTRIBUTING file?
  • Is there a duplicate/close duplicate pull request already present?
  • Does this request close any open issues? (If not, create an issue first)
  • Does your description fully describe the pull request's changes?
  • Are there any screenshots you could provide that better illustrate your change?
  • Is this a breaking change? (Does it cause existing features to not work the same?)
  • Does your code follow the code styles enforced by the project?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant