Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres psycopg2 TLS connectivity #875

Closed
1 task
nictrix opened this issue Mar 6, 2024 · 1 comment · Fixed by #905
Closed
1 task

Postgres psycopg2 TLS connectivity #875

nictrix opened this issue Mar 6, 2024 · 1 comment · Fixed by #905
Labels
enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library

Comments

@nictrix
Copy link

nictrix commented Mar 6, 2024

Describe the feature as you'd like to see it

I don't think connecting to a Postgres Database over TLS is currently possible based on what code I saw when connecting via psycopg2. I would like to use `sslmode, sslrootcert options and that doesn't appear to be possible.

What do we currently have to do now?

Please confirm if this is a valid feature to add, if so I can submit some code to enable this ability. I believe all we need to do is add on a general **kwargs parameter to the make_connection function and pass that along since psycopg2 can handle it.

Additional context

Great project by the way! Really appreciate the work put into it!

  • Is this a breaking change? No
@nictrix nictrix added enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library labels Mar 6, 2024
@josephmancuso
Copy link
Member

I agree with this. as long as we can pass it to the psycopg2 connection class we can make a configuration for it in the connection settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature that exists, works as intended but needs to be improved feature request A feature that does not yet exist but will be a good addition to the library
Projects
Status: Done
2 participants