Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Pendulum 3 #876

Open
felipehertzer opened this issue Mar 7, 2024 · 1 comment
Open

Update to Pendulum 3 #876

felipehertzer opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
major This issue can only be done in a major release because there are some breaking changes

Comments

@felipehertzer
Copy link
Contributor

Describe the bug
I'm trying to use the package with Python 3.12 but the pendulum dependencie doesn't allow it.
Is there any reason why it is locked at pendulum>=2.1,<2.2? I think it could be updated without any major change.

To Reproduce
Steps to reproduce the behavior:

  1. Use Python 3.12
  2. pip install masonite-orm
  3. See error

Expected behavior
Be able to use Masonite with Python 3.12

Desktop (please complete the following information):

  • OS: Mac OS
  • Version 14.3.1

What database are you using?

  • Type: MySQL
  • Version 8
  • Masonite ORM v2.20.0

Additional context
Any other steps you are doing or any other related information that will help us debug the problem please put here.

@felipehertzer felipehertzer added the bug An existing feature is not working as intended label Mar 7, 2024
@josephmancuso
Copy link
Member

Pendulum 3 i believe is a breaking change. so to fix this ill need to fix this and then upgrade the package to from version 2.x to version 3.x.

although this needs to be solved its not as simple as just bumping the pendulum version

@josephmancuso josephmancuso added major This issue can only be done in a major release because there are some breaking changes and removed bug An existing feature is not working as intended labels Apr 7, 2024
@josephmancuso josephmancuso self-assigned this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major This issue can only be done in a major release because there are some breaking changes
Projects
Status: No status
Development

No branches or pull requests

2 participants