Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the controllers performance better. #10

Open
MassiGy opened this issue May 21, 2023 · 3 comments
Open

Make the controllers performance better. #10

MassiGy opened this issue May 21, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MassiGy
Copy link
Owner

MassiGy commented May 21, 2023

Hey there,

Currently the controllers performance can be improved. To do so, we will:

  • Remove all the unecessary awaits.
  • Remove all the unecessary mongo queries.
  • Use Promise.all and other Promise based methods to use parallel promise execution.

Kind regards.

@MassiGy MassiGy added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 21, 2023
@ujwalkumar1995
Copy link

Hey @MassiGy
I would like to work on this. I have gone through the controller level code on a high level. Seems we could use Promise.all at few places to optimize the performance. On first look I cannot find unnecessary awaits or mongo queries. If you have seen any example of unnecessary await or mongo queries, please do let me know. I will fix those as well as part of the PR.

@MassiGy
Copy link
Owner Author

MassiGy commented May 21, 2023

Hey @ujwalkumar1995, hope that you are doing well.

Right now, I am also going through the code to optimize it. The best thing is to try your best to optimize it & then we will se what can we merge to production.

Kind regards.

@MassiGy
Copy link
Owner Author

MassiGy commented May 21, 2023

Also, please structure your branches is this way: dev-username-feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants