Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeouts for example service discovery #197

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

therealryan
Copy link
Collaborator

The initial builds on #195 shows that tests will hang forever if service discovery is blocked. That's obviously sub-optimal, so let's set some reasonable timeouts.

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@therealryan therealryan merged commit 2790eca into main Jan 11, 2023
@therealryan therealryan deleted the example_startup_hang branch January 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant