From 4ef76c262e49778dda3f48b9e8b2d58894bf3f4f Mon Sep 17 00:00:00 2001
From: Rick van Lieshout <info@rickvanlieshout.com>
Date: Sun, 24 Mar 2024 15:55:33 +0100
Subject: [PATCH] Links in the about window now open in the user's default
 browser. fixes #360

---
 CHANGELOG.md                     |  2 +-
 src/pages/settings/settings.html | 12 ++++++------
 src/pages/settings/settings.scss |  1 -
 src/scripts/settings.ts          |  6 +++++-
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 06b16f4..374f167 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - TIDAL will now close the previous notification if a new one is sent whilst the old is still visible. [#364](https://github.com/Mastermindzh/tidal-hifi/pull/364)
 - Updated developer documentation to get started in README [#365](https://github.com/Mastermindzh/tidal-hifi/pull/365)
--
+- Links in the about window now open in the user's default browser. fixes [#360](https://github.com/Mastermindzh/tidal-hifi/issues/360)
 
 ## [5.9.0]
 
diff --git a/src/pages/settings/settings.html b/src/pages/settings/settings.html
index a3672f8..8a97788 100644
--- a/src/pages/settings/settings.html
+++ b/src/pages/settings/settings.html
@@ -432,14 +432,14 @@ <h4>Upload new themes</h4>
           <img alt="tidal icon" class="about-section__icon" src="./icon.png" />
           <h4>TIDAL Hi-Fi</h4>
           <div class="about-section__version">
-            <a href="https://github.com/Mastermindzh/tidal-hifi/releases/tag/5.10.0">5.10.0</a>
+            <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/releases/tag/5.10.0">5.10.0</a>
           </div>
           <div class="about-section__links">
-            <a href="https://github.com/mastermindzh/tidal-hifi/" class="about-section__button">Github <i
-                class="fa fa-external-link"></i></a>
-            <a href="https://github.com/Mastermindzh/tidal-hifi/issues" class="about-section__button">Report an issue <i
-                class="fa fa-external-link"></i></a>
-            <a href="https://github.com/Mastermindzh/tidal-hifi/graphs/contributors"
+            <a target="_blank" href="https://github.com/mastermindzh/tidal-hifi/" class="about-section__button">Github
+              <i class="fa fa-external-link"></i></a>
+            <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/issues"
+              class="about-section__button">Report an issue <i class="fa fa-external-link"></i></a>
+            <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/graphs/contributors"
               class="about-section__button">Contributors <i class="fa fa-external-link"></i></a>
           </div>
         </section>
diff --git a/src/pages/settings/settings.scss b/src/pages/settings/settings.scss
index aa6722c..3be16a6 100644
--- a/src/pages/settings/settings.scss
+++ b/src/pages/settings/settings.scss
@@ -415,7 +415,6 @@ html {
 }
 
 // file upload
-
 .file-drop-area {
   position: relative;
   display: flex;
diff --git a/src/scripts/settings.ts b/src/scripts/settings.ts
index 49e1996..7c0536d 100644
--- a/src/scripts/settings.ts
+++ b/src/scripts/settings.ts
@@ -1,6 +1,6 @@
 import Store from "electron-store";
 
-import { BrowserWindow } from "electron";
+import { BrowserWindow, shell } from "electron";
 import path from "path";
 import { settings } from "../constants/settings";
 
@@ -134,6 +134,10 @@ export const createSettingsWindow = function () {
 
   settingsWindow.loadURL(`file://${__dirname}/../pages/settings/settings.html`);
 
+  settingsWindow.webContents.setWindowOpenHandler(({ url }) => {
+    shell.openExternal(url);
+    return { action: "deny" };
+  });
   settingsModule.settingsWindow = settingsWindow;
 };