Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #449 Discord RPC stuck on "Browsing Tidal" #450

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

HurleybirdJr
Copy link
Contributor

Fix for #449

/src/scripts/discord.ts:62

if (mediaInfo.album) {
        if (mediaInfo.album.length < 2) {  // Fix for DiscordRPC 2 character minimum
          presence.largeImageText = mediaInfo.album + " ";
        }
        else {
          presence.largeImageText = mediaInfo.album;
        }
      }

Discord API doesn't like largeImageTexts with less than 2 characters, so to fix this issue I've added an extra space to the album name, which Discord automatically trims as trailing white-space anyway.

image

Copy link

sonarcloud bot commented Aug 1, 2024

@HurleybirdJr HurleybirdJr changed the title Fix issue #449 Discord RPC stuck on "Browsing Tidal" #449 Fix issue #449 Discord RPC stuck on "Browsing Tidal" Aug 1, 2024
@Mastermindzh Mastermindzh changed the base branch from master to develop August 5, 2024 06:37
@Mastermindzh
Copy link
Owner

@HurleybirdJr,

Thanks, I'll merge later and will make the small adjustments as @Mar0xy suggested 😄.

@HurleybirdJr
Copy link
Contributor Author

Awesome, thanks 😁❤️

@Mastermindzh Mastermindzh merged commit 5b85e59 into Mastermindzh:develop Aug 5, 2024
5 checks passed
@Mastermindzh
Copy link
Owner

I will be implementing a generic fix since all fields have a minimum length of 2 apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants