Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic complains about missing email #80

Open
flrnslbch opened this issue Mar 27, 2024 · 3 comments
Open

Pydantic complains about missing email #80

flrnslbch opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@flrnslbch
Copy link

Describe the bug
The person idenfication heuristics give the impression that the email address is optional when specifying people. This is also necessary, if an author wishes to be listed by name only.
However, when I omit the email address in somesy.toml, I get the following error:

Error: 1 validation error for SomesyInput                                                                                                                                                                                     
project.people.3.email                                                                                                                                                                                                        
  Field required                                                                                                                                                                                                              
    For further information visit https://errors.pydantic.dev/2.5/v/missing   

To Reproduce

Run somesy sync on an input file that contains a person for which no email is supplied.

Expected behavior
No email is listed for this person in the output files

Environment
Provide information about versions of relevant software packages.

  • Python Version 3.10
  • Ubuntu 22.04
  • pydantic version 2.5.3
@flrnslbch flrnslbch added the bug Something isn't working label Mar 27, 2024
@mustafasoylu
Copy link
Collaborator

Most of the Author metadata like in pyproject.toml requires an email since their format is author_full_name <euthor_email>. Therefore, we made family names, given names, and email required fields. In person heuristics, what we would like to have is actually an orcid profile, which is better for recognizing humans since emails change with affiliation too.

@flrnslbch
Copy link
Author

Neither pyproject nor CITATION.cff require an email. I do not understand why somesy needs to be stricter than the output standards. For privacy reasons and/or to avoid spam authors may choose to not supply an email adress which in my opinion should be respected. Please consider reopening this issue.

@mustafasoylu mustafasoylu self-assigned this Nov 29, 2024
@mustafasoylu mustafasoylu reopened this Nov 29, 2024
@mustafasoylu mustafasoylu added enhancement New feature or request and removed bug Something isn't working labels Nov 29, 2024
@mustafasoylu
Copy link
Collaborator

Talked about this again and we agreed on there are use cases where email cannot be provided. Will be implemented on the next cycle

@mustafasoylu mustafasoylu added this to the v0.5.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants