Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pom xml support #73

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Feature/pom xml support #73

merged 10 commits into from
Feb 22, 2024

Conversation

apirogov
Copy link
Contributor

@apirogov apirogov commented Feb 16, 2024

Implementation for pom.xml

Includes fancy wrapper for dict-like access to XML to allow tomlkit-like updating features using python builtin xml elementtree.

Also some refactorings reducing copy-paste code

@apirogov apirogov marked this pull request as ready for review February 20, 2024 13:26
@apirogov apirogov assigned apirogov and unassigned apirogov Feb 20, 2024
src/somesy/commands/sync.py Outdated Show resolved Hide resolved
src/somesy/core/writer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mustafasoylu mustafasoylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mustafasoylu mustafasoylu added the enhancement New feature or request label Feb 22, 2024
@mustafasoylu mustafasoylu added this to the v0.4.0 milestone Feb 22, 2024
@mustafasoylu mustafasoylu linked an issue Feb 22, 2024 that may be closed by this pull request
@mustafasoylu mustafasoylu merged commit 6cf00b4 into main Feb 22, 2024
16 checks passed
@mustafasoylu mustafasoylu deleted the feature/pom_xml_support branch February 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sync support for Java Maven pom.xml
2 participants