Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump custodian from 2024.6.24 to 2024.10.14 #69

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 14, 2024

Bumps custodian from 2024.6.24 to 2024.10.14.

Release notes

Sourced from custodian's releases.

v2024.10.14

See changes at https://materialsproject.github.io/custodian

Changelog

Sourced from custodian's changelog.

2024.10.14

  • PR #342 from @​esoteric-ephemera (#342) Minor update to the logic of the auto_nbands check for VaspErrorHandler. This check sees if the number of bands has been updated by VASP, and currently it only checks to see if that updated number is very large. However, there are cases where the user specifies an NBANDS that is incompatible with their parallelization settings, as NBANDS must be divisible by $(\mathrm{ranks}) / (\mathrm{KPAR} \times \mathrm{NCORE})$. In these cases, VASP increases the number of bands to ensure the calculation can still proceed. This can happen in MP's band structure workflows with uniform $k$-point densities. However, since the current auto_nbands handler applies no corrections to the job, these otherwise successful runs are killed. This PR adds logic to ensure that the calculation is rerun with a higher number of bands appropriate to the parallelization setting. This is kinda redundant, since VASP already does this. But I think it has to occur this way because VaspErrorHandler is monitoring the job and flags it for an auto_nbands error. Another implementation concern: it's generally safer to decrease the number of bands since this requires a lower energy cutoff to converge each band. It might be safer to decrease NBANDS as a fix
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [custodian](https://github.com/materialsproject/custodian) from 2024.6.24 to 2024.10.14.
- [Release notes](https://github.com/materialsproject/custodian/releases)
- [Changelog](https://github.com/materialsproject/custodian/blob/master/docs/changelog.md)
- [Commits](materialsproject/custodian@v2024.6.24...v2024.10.14)

---
updated-dependencies:
- dependency-name: custodian
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 14, 2024

The following labels could not be found: dependency_updates.

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2024

Superseded by #70.

@dependabot dependabot bot closed this Oct 15, 2024
@dependabot dependabot bot deleted the dependabot/pip/main/custodian-2024.10.14 branch October 15, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants