MATRIX-7880: update new lines handling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
update new lines handling.
I think that this change actually causes quite heavy consequences, in a way that it will no longer be able to handle "prettified" html (with new lines between the tags, see previous version of "removes deleted closing-opening tag pair" spec). but since we're in full control of the html we're passing there, I'll make sure that we have a correct structure here (it actually already looks like we have a proper structure everywhere, but I would not rely on it staying that way)
https://github.com/MatrixRequirements/matrix-client-server/blob/ce05bdc0f81ec03f77fc9fae9fead51151ea95c6/server/Clouds/client/ts/sdk/utils/differs/diffHtml.ts#L23-L31