Merge pull request #15 from MatsMoll/matsei/fix-model-entity

Matsei/fix model entity

aligned/compiler/model.py

@@ -8,6 +8,7 @@
 
 from aligned.compiler.feature_factory import (
     ClassificationLabel,
+    Entity,
     EventTimestamp,
     FeatureFactory,
     FeatureReferencable,
@@ -230,6 +231,8 @@ class MyModel(ModelContract):
                 probability_features[feature_name] = probability_features.get(feature_name, set()).union(
                     {feature}
                 )
+            elif isinstance(feature, Entity):
+                inference_view.entities.add(feature.feature())
             elif isinstance(feature, FeatureFactory):
                 inference_view.features.add(feature.feature())
 

aligned/schemas/model.py

@@ -83,8 +83,10 @@ def request(self, name: str) -> RetrivalRequest:
 
     def request_for(self, features: set[str], name: str) -> RetrivalRequest:
         entities = self.entities
-        if self.model_version_column:
-            entities.add(self.model_version_column)
+
+        # if self.model_version_column:
+        #     entities.add(self.model_version_column)
+
         return RetrivalRequest(
             name=name,
             location=FeatureLocation.model(name),

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "aligned"
-version = "0.0.28"
+version = "0.0.29"
 description = "A scalable feature store that makes it easy to align offline and online ML systems"
 authors = ["Mats E. Mollestad <mats@mollestad.no>"]
 license = "Apache-2.0"